Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and fix some issues

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jiancheng Xue <xuejiancheng@hisilicon.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and fix some issues
Date	Tue, 10 May 2016 13:50:01 +0200
Message-ID	<rxekN-1Bh-1@gated-at.bofh.it> (permalink)
References	<rxcj0-8b4-5@gated-at.bofh.it> <rxcj1-8b4-29@gated-at.bofh.it> <rxdRM-1mg-19@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.67.217.211]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A090203.5731CA0E.003D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	861f50ee6cf3828816c92c280b92f1ae
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	<mturquette@baylibre.com>, <sboyd@codeaurora.org>, <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <yanhaifeng@hisilicon.com>, <haojian.zhuang@linaro.org>, <zhangfei.gao@linaro.org>, <xuwei5@hisilicon.com>, <yanghongwei@hisilicon.com>
X-Original-Date	Tue, 10 May 2016 19:46:05 +0800
X-Original-Message-ID	<5731C9FD.1010502@hisilicon.com>
X-Original-References	<1462871953-26606-1-git-send-email-xuejiancheng@hisilicon.com> <1462871953-26606-6-git-send-email-xuejiancheng@hisilicon.com> <1462878595.3050.6.camel@pengutronix.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1398011

Show key headers only | View raw

Hi Philipp,

On 2016/5/10 19:09, Philipp Zabel wrote:
> Am Dienstag, den 10.05.2016, 17:19 +0800 schrieb Jiancheng Xue:
>> 1. Add driver remove path.
>> 2. Fix some issues.
>>    -Fix the ordering issue about clock provider being published.
>>    -Add error checking upon registering clocks.
>>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
>> ---
>>  drivers/clk/hisilicon/clk-hi3519.c | 116 ++++++++++++++++++++++++++++++++-----
>>  1 file changed, 100 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/clk/hisilicon/clk-hi3519.c b/drivers/clk/hisilicon/clk-hi3519.c
>> index 715c730..51b173e 100644
>> --- a/drivers/clk/hisilicon/clk-hi3519.c
>> +++ b/drivers/clk/hisilicon/clk-hi3519.c
> [...]
>> -	rstc = hisi_reset_init(np);
>> -	if (!rstc)
> [...]
>> +	crg->rstc = hisi_reset_init(pdev);
>> +	if (!crg->rstc)
> [...]
> 
> The hisi_reset_init(np) -> hisi_reset_init(pdev) change should be part
> of patch 1.
> 
OK. I'll redivide this patch set and resend it. Thank you!

Regards,
Jiancheng

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] clk: hisilicon: Fix some problems of clk-hi3519 Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
  [PATCH 1/5] reset: hisilicon: change the definition of hisi_reset_init Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
    Re: [PATCH 1/5] reset: hisilicon: change the definition of  hisi_reset_init Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-10 13:20 +0200
  [PATCH 3/5] clk: hisilicon: add error processing for hisi_clk_register_* functions Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
  [PATCH 2/5] clk: hisilicon: add hisi_clk_alloc function. Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
  [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and fix some issues Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
    Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and  fix some issues Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-10 13:20 +0200
      Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and  fix some issues Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 13:50 +0200

csiph-web