Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1397991

Re: [PATCH 1/5] reset: hisilicon: change the definition of hisi_reset_init

From Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 1/5] reset: hisilicon: change the definition of hisi_reset_init
Date 2016-05-10 13:20 +0200
Message-ID <rxdRL-1mg-3@gated-at.bofh.it> (permalink)
References <rxcj0-8b4-5@gated-at.bofh.it> <rxcj0-8b4-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Jiancheng,

Am Dienstag, den 10.05.2016, 17:19 +0800 schrieb Jiancheng Xue:
> Change the input arguments type to struct platform_device pointer.
> 
> Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
[...]
> diff --git a/drivers/clk/hisilicon/reset.h b/drivers/clk/hisilicon/reset.h
> index 677d773..9a69374 100644
> --- a/drivers/clk/hisilicon/reset.h
> +++ b/drivers/clk/hisilicon/reset.h
> @@ -22,10 +22,11 @@ struct device_node;
>  struct hisi_reset_controller;
>  
>  #ifdef CONFIG_RESET_CONTROLLER
> -struct hisi_reset_controller *hisi_reset_init(struct device_node *np);
> +struct hisi_reset_controller *hisi_reset_init(struct platform_device *pdev);

Changing this without changing the call to hisi_reset_init() in 
hi3519_clk_probe at the same time will break compilation until
patch 5 is applied.

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] clk: hisilicon: Fix some problems of clk-hi3519 Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
  [PATCH 1/5] reset: hisilicon: change the definition of hisi_reset_init Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
    Re: [PATCH 1/5] reset: hisilicon: change the definition of  hisi_reset_init Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-10 13:20 +0200
  [PATCH 3/5] clk: hisilicon: add error processing for hisi_clk_register_* functions Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
  [PATCH 2/5] clk: hisilicon: add hisi_clk_alloc function. Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
  [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and fix some issues Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 11:40 +0200
    Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and  fix some issues Philipp Zabel <p.zabel@pengutronix.de> - 2016-05-10 13:20 +0200
      Re: [PATCH 5/5] clk: hisilicon: hi3519: add driver remove path and  fix some issues Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-05-10 13:50 +0200

csiph-web