Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time

From	Borislav Petkov <bp@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time
Date	2016-05-10 13:30 +0200
Message-ID	<rxe1s-1qz-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <rwZYv-4gl-47@gated-at.bofh.it> <rx1xh-6ah-39@gated-at.bofh.it> <rx1QD-6kP-33@gated-at.bofh.it> <rx1QD-6kP-35@gated-at.bofh.it> <rx8S5-4qk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 10, 2016 at 07:58:54AM +0200, Ingo Molnar wrote:
> Ok, could you guys please update the code and the changelog as well,
> and also rename that horribly named prepare_level4() function?

Oh, and while at it, call that new function at the beginning of
choose_random_location() before the first call to add_identity_map()
through mem_avoid_init() and make the code flow even clearer this way
instead of doing funky checks like

        if (!level4p)
                prepare_level4();

Thanks.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

Thread

[PATCH v7 0/9] x86/KASLR: Randomize virtual address separately Kees Cook <keescook@chromium.org> - 2016-05-09 22:30 +0200
  [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Kees Cook <keescook@chromium.org> - 2016-05-09 22:30 +0200
    Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Yinghai Lu <yinghai@kernel.org> - 2016-05-10 00:10 +0200
      Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Yinghai Lu <yinghai@kernel.org> - 2016-05-10 00:30 +0200
      Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Kees Cook <keescook@chromium.org> - 2016-05-10 00:30 +0200
        Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Yinghai Lu <yinghai@kernel.org> - 2016-05-10 00:30 +0200
          Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Ingo Molnar <mingo@kernel.org> - 2016-05-10 08:00 +0200
            Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Borislav Petkov <bp@suse.de> - 2016-05-10 13:30 +0200
      Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Yinghai Lu <yinghai@kernel.org> - 2016-05-10 00:30 +0200
    [tip:x86/boot] x86/KASLR: Initialize mapping_info every time tip-bot for Kees Cook <tipbot@zytor.com> - 2016-05-10 10:50 +0200
  [PATCH v7 8/9] x86/KASLR: Add physical address randomization >4G Kees Cook <keescook@chromium.org> - 2016-05-09 22:30 +0200
  [PATCH v7 2/9] x86/boot: Add missing file header comments Kees Cook <keescook@chromium.org> - 2016-05-09 22:30 +0200
    [tip:x86/boot] x86/boot: Add missing file header comments tip-bot for Kees Cook <tipbot@zytor.com> - 2016-05-10 10:50 +0200

csiph-web