Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1397371

[PATCH v7 2/9] x86/boot: Add missing file header comments

Show all headers | View raw

There were some files with missing header comments. Since they are
included from both compressed and regular kernels, make note of that.
Also corrects a typo in the mem_avoid comments.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 arch/x86/boot/compressed/kaslr.c     | 2 +-
 arch/x86/boot/early_serial_console.c | 4 ++++
 arch/x86/mm/ident_map.c              | 5 +++++
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index f82975b0f9d6..3f0692dcd30d 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -163,7 +163,7 @@ static bool mem_overlaps(struct mem_vector *one, struct mem_vector *two)
  * memory ranges lead to really hard to debug boot failures.
  *
  * The initrd, cmdline, and boot_params are trivial to identify for
- * avoiding. The are MEM_AVOID_INITRD, MEM_AVOID_CMDLINE, and
+ * avoiding. They are MEM_AVOID_INITRD, MEM_AVOID_CMDLINE, and
  * MEM_AVOID_BOOTPARAMS respectively below.
  *
  * What is not obvious how to avoid is the range of memory that is used
diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 45a07684bbab..f0b8d6d93164 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -1,3 +1,7 @@
+/*
+ * Serial port routines for use during early boot reporting. This code is
+ * included from both the compressed kernel and the regular kernel.
+ */
 #include "boot.h"
 
 #define DEFAULT_SERIAL_PORT 0x3f8 /* ttyS0 */
diff --git a/arch/x86/mm/ident_map.c b/arch/x86/mm/ident_map.c
index 751ca920773a..ec21796ac5fd 100644
--- a/arch/x86/mm/ident_map.c
+++ b/arch/x86/mm/ident_map.c
@@ -1,3 +1,7 @@
+/*
+ * Helper routines for building identity mapping page tables. This is
+ * included by both the compressed kernel and the regular kernel.
+ */
 
 static void ident_pmd_init(unsigned long pmd_flag, pmd_t *pmd_page,
 			   unsigned long addr, unsigned long end)
@@ -10,6 +14,7 @@ static void ident_pmd_init(unsigned long pmd_flag, pmd_t *pmd_page,
 			set_pmd(pmd, __pmd(addr | pmd_flag));
 	}
 }
+
 static int ident_pud_init(struct x86_mapping_info *info, pud_t *pud_page,
 			  unsigned long addr, unsigned long end)
 {
-- 
2.6.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/9] x86/KASLR: Randomize virtual address separately Kees Cook <keescook@chromium.org> - 2016-05-09 22:30 +0200
  [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Kees Cook <keescook@chromium.org> - 2016-05-09 22:30 +0200
    Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Yinghai Lu <yinghai@kernel.org> - 2016-05-10 00:10 +0200
      Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Yinghai Lu <yinghai@kernel.org> - 2016-05-10 00:30 +0200
      Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Kees Cook <keescook@chromium.org> - 2016-05-10 00:30 +0200
        Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Yinghai Lu <yinghai@kernel.org> - 2016-05-10 00:30 +0200
          Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Ingo Molnar <mingo@kernel.org> - 2016-05-10 08:00 +0200
            Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Borislav Petkov <bp@suse.de> - 2016-05-10 13:30 +0200
      Re: [PATCH v7 1/9] x86/KASLR: Initialize mapping_info every time Yinghai Lu <yinghai@kernel.org> - 2016-05-10 00:30 +0200
    [tip:x86/boot] x86/KASLR: Initialize mapping_info every time tip-bot for Kees Cook <tipbot@zytor.com> - 2016-05-10 10:50 +0200
  [PATCH v7 8/9] x86/KASLR: Add physical address randomization >4G Kees Cook <keescook@chromium.org> - 2016-05-09 22:30 +0200
  [PATCH v7 2/9] x86/boot: Add missing file header comments Kees Cook <keescook@chromium.org> - 2016-05-09 22:30 +0200
    [tip:x86/boot] x86/boot: Add missing file header comments tip-bot for Kees Cook <tipbot@zytor.com> - 2016-05-10 10:50 +0200

csiph-web