Re: [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT
Date	Tue, 10 May 2016 12:40:02 +0200
Message-ID	<rxdf4-KB-19@gated-at.bofh.it> (permalink)
References	<rxcCp-8kL-61@gated-at.bofh.it> <rxcCq-8kL-89@gated-at.bofh.it> <rxcCq-8kL-87@gated-at.bofh.it> <rxcM2-qT-23@gated-at.bofh.it> <rxcM2-qT-21@gated-at.bofh.it> <rxd5o-FH-15@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.24,604,1455004800"; d="asc'?scan'208";a="976404470"
User-Agent	Notmuch/0.22+11~g124a67e (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	79
Organization	linux.* mail to news gateway
X-Original-Cc	tony@atomide.com, Joao.Pinto@synopsys.com, sergei.shtylyov@cogentembedded.com, peter.chen@freescale.com, jun.li@freescale.com, grygorii.strashko@ti.com, yoshihiro.shimoda.uh@renesas.com, nsekhar@ti.com, b-liu@ti.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 10 May 2016 13:33:51 +0300
X-Original-Message-ID	<87mvnygq28.fsf@linux.intel.com>
X-Original-References	<1462873919-20532-1-git-send-email-rogerq@ti.com> <1462873919-20532-4-git-send-email-rogerq@ti.com> <87futqi6gs.fsf@linux.intel.com> <5731B118.1010705@ti.com> <874ma6i5zi.fsf@linux.intel.com> <5731B6AD.9070108@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1397978

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Roger Quadros <rogerq@ti.com> writes:
> On 10/05/16 13:04, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Roger Quadros <rogerq@ti.com> writes:
>>> On 10/05/16 12:54, Felipe Balbi wrote:
>>>>
>>>> Hi,
>>>>
>>>> Roger Quadros <rogerq@ti.com> writes:
>>>>> TRM [1] recommends that POWERPRESENT bit must not be
>>>>> set and left at it's default value of 0.
>>>>>
>>>>> [1] OMAP542x TRM - http://www.ti.com/lit/pdf/swpu249
>>>>> Section 23.11.4.5.1 Mailbox VBUS/ID Management
>>>>>
>>>>> "Because PIPE powerpresent has a different meaning in host and in device mode,
>>>>> and because of the redundancy with the UTMI signals, the controller ORes
>>>>> together the appropriate PIPE and UTMI inputs to create its internal
>>>>> VBUS status. For that reason, it is recommended to leave field
>>>>> USBOTGSS_UTMI_OTG_STATUS[9] POWERPRESENT at its default value (=0), and only to
>>>>> fill in the USB2 VBUS status fields in the same register."
>>>>>
>>>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>>>
>>>> to make sure we avoid regressions, do you mind sharing on which
>>>> platforms you tested this patch ?
>>>>
>>> I tested this on omap5-uevm and dra7-evm.
>>> My am437x board stopped working so couldn't test on that one.
>> 
>> would you have a colleague or perhaps an automated test-farm which could
>> run the test for you ? :-)
>> 
>> I can take the patch, no problem, but if there are any regressions don't
>> blame me :-)
>> 
> Don't worry, blame is on the TRM then :).

alright then, so seems like v8 will be queued. Just remember we're
pretty close to opening the merge window and I have already sent a pull
request to Greg. On the bright side, your patches will sit in linux-next
for quite some time :-) (well, until -rc1 is tagged)

-- 
balbi

Thread

Re: [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT Felipe Balbi <balbi@kernel.org> - 2016-05-10 12:00 +0200
  Re: [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT Felipe Balbi <balbi@kernel.org> - 2016-05-10 12:10 +0200
    Re: [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT Roger Quadros <rogerq@ti.com> - 2016-05-10 12:30 +0200
      Re: [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT Felipe Balbi <balbi@kernel.org> - 2016-05-10 12:40 +0200
    Re: [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT Roger Quadros <rogerq@ti.com> - 2016-05-10 12:30 +0200
  Re: [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT Roger Quadros <rogerq@ti.com> - 2016-05-10 12:10 +0200

csiph-web