Re: [PATH v2] NVMe: init nvme queue before enabling irq

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATH v2] NVMe: init nvme queue before enabling irq
Date	Thu, 12 May 2016 09:20:02 +0200
Message-ID	<rxT4C-Ri-7@gated-at.bofh.it> (permalink)
References	<qSYuT-5ao-35@gated-at.bofh.it> <rxyCU-5ns-55@gated-at.bofh.it> <rxHGa-6be-21@gated-at.bofh.it>
X-Original-To	Keith Busch <keith.busch@intel.com>
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-1
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.6.0 (2016-04-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	Wenbo Wang <mail_weber_wang@163.com>, axboe@fb.com, stable@vger.kernel.org, wenwei.tao@memblaze.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Wenbo Wang <wenbo.wang@memblaze.com>
X-Original-Date	Thu, 12 May 2016 09:12:08 +0200
X-Original-Message-ID	<20160512071207.GC25134@c203.arch.suse.de>
X-Original-References	<1453286915-18814-1-git-send-email-mail_weber_wang@163.com> <e41c65a6b6637ef16f7f11ac147a9466@suse.de> <20160511191632.GC31047@localhost.localdomain>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1399709

Show key headers only | View raw

On Wed, May 11, 2016 at 03:16:33PM -0400, Keith Busch wrote:
> On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote:
> > What ever happened to this patch?
> > I can easily reproduce the bug using
> > while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done
> 
> This patch was supposed to fix using a doorbell between resets when the
> driver had BAR0 unmapped. We don't ever unmap the bar anymore, so this
> patch shouldn't be necessary: the doorbell is already set during queue
> allocation before requset_irq.
> 
> The test doesn't seem like this patch would help either. It sounds
> more like you're hitting somethine else if you don't have this fix:
> 
>   https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=9bf2b972afeaffd173fe2ce211ebc555ea7e8a87
> 
> If you do have that fix already, I'd like to see the panic stack trace
> (assuming that's what happened).

Yup, having that commit.

I'm going to reproduce (with current Linus' master) w/o the patch applied
later today.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Thread

Re: [PATH v2] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-11 11:30 +0200
  Re: [PATH v2] NVMe: init nvme queue before enabling irq Keith Busch <keith.busch@intel.com> - 2016-05-11 21:10 +0200
    Re: [PATH v2] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-12 09:20 +0200
    Re: [PATH v2] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-12 13:00 +0200

csiph-web