Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1399435

Re: [PATH v2] NVMe: init nvme queue before enabling irq

From Keith Busch <keith.busch@intel.com>
Newsgroups linux.kernel
Subject Re: [PATH v2] NVMe: init nvme queue before enabling irq
Date 2016-05-11 21:10 +0200
Message-ID <rxHGa-6be-21@gated-at.bofh.it> (permalink)
References <qSYuT-5ao-35@gated-at.bofh.it> <rxyCU-5ns-55@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, May 11, 2016 at 11:25:16AM +0200, Johannes Thumshirn wrote:
> What ever happened to this patch?
> I can easily reproduce the bug using
> while [ true ]; do rmmod nvme nvme_core; modprobe nvme; done

This patch was supposed to fix using a doorbell between resets when the
driver had BAR0 unmapped. We don't ever unmap the bar anymore, so this
patch shouldn't be necessary: the doorbell is already set during queue
allocation before requset_irq.

The test doesn't seem like this patch would help either. It sounds
more like you're hitting somethine else if you don't have this fix:

  https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=9bf2b972afeaffd173fe2ce211ebc555ea7e8a87

If you do have that fix already, I'd like to see the panic stack trace
(assuming that's what happened).

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATH v2] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-11 11:30 +0200
  Re: [PATH v2] NVMe: init nvme queue before enabling irq Keith Busch <keith.busch@intel.com> - 2016-05-11 21:10 +0200
    Re: [PATH v2] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-12 09:20 +0200
    Re: [PATH v2] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-05-12 13:00 +0200

csiph-web