Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES
Date	2016-05-11 17:20 +0200
Message-ID	<rxE5B-2n7-45@gated-at.bofh.it> (permalink)
References	<rxppT-4nc-3@gated-at.bofh.it> <rxppV-4nc-25@gated-at.bofh.it> <rxDMf-1Nm-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Dave Hansen <dave.hansen@linux.intel.com> wrote:

> On 05/10/2016 04:29 PM, Yu-cheng Yu wrote:
> > XSAVES uses compacted format and is a kernel instruction. The kernel
> > should use standard-format, non-supervisor state data for PTRACE.
> > 
> > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
> 
> This looks fine.  There are a few comments that could use some sprucing
> up, like:
> 
> +	/*
> +	 * Reject if the user sets any forbidden features.
> +	 */
> 
> But it's minor stuff.
> 
> Reviewed-by: Dave Hansen <dave.hansen@intel.com>

Well it's too late for v4.7 due to intrusiveness, so please refine the series and 
also incorporate the cleanups requested by Boris. I can put it into -tip whenever 
you guys submit it, but it will have to wait for v4.8 most likely.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-05-11 01:40 +0200
  Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-05-11 17:00 +0200
    Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES Ingo Molnar <mingo@kernel.org> - 2016-05-11 17:20 +0200

csiph-web