Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1399214

Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES

From Dave Hansen <dave.hansen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES
Date 2016-05-11 17:00 +0200
Message-ID <rxDMf-1Nm-39@gated-at.bofh.it> (permalink)
References <rxppT-4nc-3@gated-at.bofh.it> <rxppV-4nc-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 05/10/2016 04:29 PM, Yu-cheng Yu wrote:
> XSAVES uses compacted format and is a kernel instruction. The kernel
> should use standard-format, non-supervisor state data for PTRACE.
> 
> Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>

This looks fine.  There are a few comments that could use some sprucing
up, like:

+	/*
+	 * Reject if the user sets any forbidden features.
+	 */

But it's minor stuff.

Reviewed-by: Dave Hansen <dave.hansen@intel.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-05-11 01:40 +0200
  Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-05-11 17:00 +0200
    Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES Ingo Molnar <mingo@kernel.org> - 2016-05-11 17:20 +0200

csiph-web