Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1399076

Re: [PATCH 03/10] x86, perf: Add Top Down events to Intel Core

Show all headers | View raw

On Thu, May 05, 2016 at 04:04:00PM -0700, Andi Kleen wrote:

SNIP

> +
> +EVENT_ATTR_STR_HT(topdown-total-slots, td_total_slots,
> +	"event=0x3c,umask=0x0",			/* cpu_clk_unhalted.thread */
> +	"event=0x3c,umask=0x0,any=1");		/* cpu_clk_unhalted.thread_any */
> +EVENT_ATTR_STR_HT(topdown-total-slots.scale, td_total_slots_scale, "4", "2");
> +EVENT_ATTR_STR(topdown-slots-issued, td_slots_issued,
> +	"event=0xe,umask=0x1");			/* uops_issued.any */
> +EVENT_ATTR_STR(topdown-slots-retired, td_slots_retired,
> +	"event=0xc2,umask=0x2");		/* uops_retired.retire_slots */
> +EVENT_ATTR_STR(topdown-fetch-bubbles, td_fetch_bubbles,
> +	"event=0x9c,umask=0x1");		/* idq_uops_not_delivered_core */
> +EVENT_ATTR_STR_HT(topdown-recovery-bubbles, td_recovery_bubbles,
> +	"event=0xd,umask=0x3,cmask=1",		/* int_misc.recovery_cycles */
> +	"event=0xd,umask=0x3,cmask=1,any=1");	/* int_misc.recovery_cycles_any */
> +EVENT_ATTR_STR_HT(topdown-recovery-bubbles.scale, td_recovery_bubbles_scale,
> +	"4", "2");
> +
>  struct attribute *snb_events_attrs[] = {
>  	EVENT_PTR(mem_ld_snb),
>  	EVENT_PTR(mem_st_snb),
> +	EVENT_PTR(td_slots_issued),
> +	EVENT_PTR(td_slots_retired),
> +	EVENT_PTR(td_fetch_bubbles),
> +	EVENT_PTR(td_total_slots),
> +	EVENT_PTR(td_total_slots_scale),
> +	EVENT_PTR(td_recovery_bubbles),
> +	EVENT_PTR(td_recovery_bubbles_scale),

Peter, Ingo,
any thoughts about adding these events? The rest of the
tooling code is based on them being accepted..

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Add top down metrics to perf stat Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
  [PATCH 05/10] x86, perf: Use new topology_max_smt_threads() in HT leak workaround Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
  [PATCH 10/10] perf, tools, stat: Add extra output of counter values with -vv Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
    Re: [PATCH 10/10] perf, tools, stat: Add extra output of counter  values with -vv Jiri Olsa <jolsa@redhat.com> - 2016-05-12 10:10 +0200
  [PATCH 07/10] perf, tools, stat: Scale values by unit before metrics Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
    Re: [PATCH 07/10] perf, tools, stat: Scale values by unit before  metrics Jiri Olsa <jolsa@redhat.com> - 2016-05-07 21:20 +0200
    [tip:perf/core] perf stat: Scale values by unit before metrics tip-bot for Andi Kleen <tipbot@zytor.com> - 2016-05-10 22:40 +0200
  [PATCH 09/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
  [PATCH 04/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
  [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
    Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for  integer scales Jiri Olsa <jolsa@redhat.com> - 2016-05-07 21:20 +0200
      Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for  integer scales Andi Kleen <andi@firstfloor.org> - 2016-05-07 21:30 +0200
        Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for  integer scales Jiri Olsa <jolsa@redhat.com> - 2016-05-11 15:10 +0200
          Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for  integer scales Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-11 18:50 +0200
  [PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
    Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT  status Peter Zijlstra <peterz@infradead.org> - 2016-05-09 11:50 +0200
      Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT  status Andi Kleen <ak@linux.intel.com> - 2016-05-09 16:30 +0200
        Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT  status Peter Zijlstra <peterz@infradead.org> - 2016-05-09 16:40 +0200
    Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT  status Ingo Molnar <mingo@kernel.org> - 2016-05-12 10:10 +0200
  [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
    Re: [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Peter Zijlstra <peterz@infradead.org> - 2016-05-11 15:30 +0200
    Re: [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Jiri Olsa <jolsa@redhat.com> - 2016-05-11 15:30 +0200
    Re: [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Ingo Molnar <mingo@kernel.org> - 2016-05-12 10:20 +0200
  [PATCH 08/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
  Re: Add top down metrics to perf stat Jiri Olsa <jolsa@redhat.com> - 2016-05-12 09:50 +0200

csiph-web