Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1396355
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales |
| Date | 2016-05-07 21:30 +0200 |
| Message-ID | <rwg5k-7CS-13@gated-at.bofh.it> (permalink) |
| References | <rvAz7-1bh-5@gated-at.bofh.it> <rvAz8-1bh-25@gated-at.bofh.it> <rwfVE-7th-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> > if (csv_output) {
> > - fmt = sc != 1.0 ? "%.2f%s" : "%.0f%s";
> > + fmt = floor(sc) != sc ? "%.2f%s" : "%.0f%s";
> > } else {
> > if (big_num)
> > - fmt = sc != 1.0 ? "%'18.2f%s" : "%'18.0f%s";
> > + fmt = floor(sc) != sc ? "%'18.2f%s" : "%'18.0f%s";
> > else
> > - fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";
> > + fmt = floor(sc) != sc ? "%18.2f%s" : "%18.0f%s";
>
> how about the rest of the code? we display % also in print_running
> and print_noise_pct functions and maybe some place else
For those it doesn't matter. In fact it's probably better there
to always show the fractions.
It is just confusing for metrics.
-Andi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Add top down metrics to perf stat Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
[PATCH 05/10] x86, perf: Use new topology_max_smt_threads() in HT leak workaround Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
[PATCH 10/10] perf, tools, stat: Add extra output of counter values with -vv Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
Re: [PATCH 10/10] perf, tools, stat: Add extra output of counter values with -vv Jiri Olsa <jolsa@redhat.com> - 2016-05-12 10:10 +0200
[PATCH 07/10] perf, tools, stat: Scale values by unit before metrics Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
Re: [PATCH 07/10] perf, tools, stat: Scale values by unit before metrics Jiri Olsa <jolsa@redhat.com> - 2016-05-07 21:20 +0200
[tip:perf/core] perf stat: Scale values by unit before metrics tip-bot for Andi Kleen <tipbot@zytor.com> - 2016-05-10 22:40 +0200
[PATCH 09/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
[PATCH 04/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
[PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales Jiri Olsa <jolsa@redhat.com> - 2016-05-07 21:20 +0200
Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen <andi@firstfloor.org> - 2016-05-07 21:30 +0200
Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales Jiri Olsa <jolsa@redhat.com> - 2016-05-11 15:10 +0200
Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-05-11 18:50 +0200
[PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Peter Zijlstra <peterz@infradead.org> - 2016-05-09 11:50 +0200
Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen <ak@linux.intel.com> - 2016-05-09 16:30 +0200
Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Peter Zijlstra <peterz@infradead.org> - 2016-05-09 16:40 +0200
Re: [PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Ingo Molnar <mingo@kernel.org> - 2016-05-12 10:10 +0200
[PATCH 03/10] x86, perf: Add Top Down events to Intel Core Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
Re: [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Peter Zijlstra <peterz@infradead.org> - 2016-05-11 15:30 +0200
Re: [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Jiri Olsa <jolsa@redhat.com> - 2016-05-11 15:30 +0200
Re: [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Ingo Molnar <mingo@kernel.org> - 2016-05-12 10:20 +0200
[PATCH 08/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen <andi@firstfloor.org> - 2016-05-06 01:10 +0200
Re: Add top down metrics to perf stat Jiri Olsa <jolsa@redhat.com> - 2016-05-12 09:50 +0200
csiph-web