Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1396538

RE: [PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings

Show all headers | View raw

Fom: Philippe Reynes <tremyfr@gmail.com> Sent: Monday, May 09, 2016 5:45 AM
> To: Fugang Duan <fugang.duan@nxp.com>; davem@davemloft.net;
> ben@decadent.org.uk; kan.liang@intel.com; decot@googlers.com;
> aduyck@mirantis.com; jiri@mellanox.com; jacob.e.keller@intel.com;
> tom@herbertland.com; andrew@lunn.ch
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Philippe Reynes
> <tremyfr@gmail.com>
> Subject: [PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings
> 
> Ethtool callbacks {get|set}_link_ksettings may be the same for many drivers. So
> we add two generics callbacks ethtool_op_{get|set}_link_ksettings.
> 
> To use those generics callbacks, the ethernet driver must use the pointer
> phydev contained in struct net_device, and not use a private structure to store
> this pointer.
> 
> Changelog:
> v2:
> - use generic function instead of macro
> - ethernet driver use the pointer phydev provided by struct net_device
>   Those idea were provided by Ben Hutchings,
>   and Florian Fainelli acknowledge them.
> 
> Philippe Reynes (3):
>   net: core: ethtool: add ethtool_op_{get|set}_link_ksettings
>   net: ethernet: fec: use phydev from struct net_device
>   net: ethernet: fec: use ethtool_op_{get|set}_link_ksettings
> 
>  drivers/net/ethernet/freescale/fec.h      |    1 -
>  drivers/net/ethernet/freescale/fec_main.c |   71 +++++++++--------------------
>  include/linux/ethtool.h                   |    5 ++
>  net/core/ethtool.c                        |   24 ++++++++++
>  4 files changed, 50 insertions(+), 51 deletions(-)
> 
> --
> 1.7.4.4

Acked-by: Fugang Duan <fugang.duan@nxp.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 23:50 +0200
  [PATCH v2 3/3] net: ethernet: fec: use ethtool_op_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 23:50 +0200
  [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 23:50 +0200
    Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct  net_device Ben Hutchings <ben@decadent.org.uk> - 2016-05-09 00:30 +0200
      Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device Philippe Reynes <tremyfr@gmail.com> - 2016-05-09 00:50 +0200
        Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct  net_device Ben Hutchings <ben@decadent.org.uk> - 2016-05-09 01:10 +0200
  RE: [PATCH v2 0/3] net: ethtool: add  ethtool_op_{get|set}_link_ksettings Fugang Duan <fugang.duan@nxp.com> - 2016-05-09 04:00 +0200

csiph-web