Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device

From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device
Date	2016-05-09 01:10 +0200
Message-ID	<rwFZL-82O-3@gated-at.bofh.it> (permalink)
References	<rwEKl-6rk-9@gated-at.bofh.it> <rwEKm-6rk-19@gated-at.bofh.it> <rwFn3-7dV-11@gated-at.bofh.it> <rwFGp-7qe-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 2016-05-09 at 00:47 +0200, Philippe Reynes wrote:
> On 09/05/16 00:22, Ben Hutchings wrote:
> > 
> > On Sun, 2016-05-08 at 23:44 +0200, Philippe Reynes wrote:
> > > 
> > > The private structure contain a pointer to phydev, but the structure
> > > net_device already contain such pointer. So we can remove the pointer
> > > phydev in the private structure, and update the driver to use the one
> > > contained in struct net_device.
> > But there is no central code that updates the pointer, so:
> The function phy_attach_direct and phy_detach update the pointer
> phydev in the struct net_device.
[...]
> So from my understanding, those two lines aren't usefull.
> May you confirm that I'm on the right way please ?

Sorry, you're right.

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.

Thread

[PATCH v2 0/3] net: ethtool: add ethtool_op_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 23:50 +0200
  [PATCH v2 3/3] net: ethernet: fec: use ethtool_op_{get|set}_link_ksettings Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 23:50 +0200
  [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device Philippe Reynes <tremyfr@gmail.com> - 2016-05-08 23:50 +0200
    Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct  net_device Ben Hutchings <ben@decadent.org.uk> - 2016-05-09 00:30 +0200
      Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct net_device Philippe Reynes <tremyfr@gmail.com> - 2016-05-09 00:50 +0200
        Re: [PATCH v2 2/3] net: ethernet: fec: use phydev from struct  net_device Ben Hutchings <ben@decadent.org.uk> - 2016-05-09 01:10 +0200
  RE: [PATCH v2 0/3] net: ethtool: add  ethtool_op_{get|set}_link_ksettings Fugang Duan <fugang.duan@nxp.com> - 2016-05-09 04:00 +0200

csiph-web