Re: [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure
Date	Sat, 07 May 2016 04:30:01 +0200
Message-ID	<rw0ad-1fb-1@gated-at.bofh.it> (permalink)
References	<rvRJD-YG-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject; bh=8BSWMjRfWTvzmw1boY7z0yncsyArSx2h8qDTy/QND8Y=; b=H75SFaIbeDFu3FFQ+dCSccQ62M mIqgJSeodfN+kjvlDXDtqoLAPLhcn50+J6vS5I8X4QHdtHLtDhw0n8yds9s5oAFWJC6wx07hF16rq sio4bQhsaxabnS/DYRqJX4/uahL7KvTAYwrESA16myhJGPSA7cHbSGZ3UyVmiy6bYz4Td+eo6Pc6u qOeaeC8RdgivZIElvpjFY9S+Rk89eIOG3llxfNAv6AnMsZp4sc9Ew/OPGUeFChup45676sV9in6Fv LI7O1vrPlahte/5CDlVYf02dIKV8L8/CjUCZNX/ssP4gxibOE1k3pKfEFuF67tglQTB/lhWRBQfjB 1yl/QAgw==;
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	7bit
X-Authenticated_Sender	linux@roeck-us.net
X-Outgoing-Spam-Status	No, score=-1.0
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - bh-25.webhostbox.net
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via	bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net
X-Authenticated-Sender	bh-25.webhostbox.net: linux@roeck-us.net
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, stable@vger.kernel.org
X-Original-Date	Fri, 6 May 2016 19:22:58 -0700
X-Original-Message-ID	<572D5182.9090808@roeck-us.net>
X-Original-References	<146255559866.32780.5399379827409805110.stgit@dwillia2-desk3.amr.corp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1396224

Show key headers only | View raw

On 05/06/2016 10:26 AM, Dan Williams wrote:
> I had relied on the kbuild robot for cross build coverage, however it
> only builds alpha_defconfig.  Switch from HPAGE_SIZE to PMD_SIZE, which
> is more widely defined.
>
> Fixes: 658922e57b84 ("libnvdimm, pfn: fix memmap reservation sizing")
> Cc: <stable@vger.kernel.org>
> Reported-by: Guenter Roeck <guenter@roeck-us.net>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Passes at least all my tests.

Tested-by: Guenter Roeck <linux@roeck-us.net>

Nitpick below.

> ---
>   drivers/nvdimm/pmem.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 5101f3ab4f29..e5a8bf032ec9 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -404,7 +404,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn)
>   		 * vmemmap_populate_hugepages() allocates the memmap array in
>   		 * HPAGE_SIZE chunks.
PMD_SIZE

>   		 */
> -		memmap_size = ALIGN(64 * npfns, HPAGE_SIZE);
> +		memmap_size = ALIGN(64 * npfns, PMD_SIZE);
>   		offset = ALIGN(start + SZ_8K + memmap_size, nd_pfn->align)
>   			- start;
>   	} else if (nd_pfn->mode == PFN_MODE_RAM)
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure Dan Williams <dan.j.williams@intel.com> - 2016-05-06 19:30 +0200
  Re: [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure Guenter Roeck <linux@roeck-us.net> - 2016-05-07 04:30 +0200

csiph-web