Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395994 > unrolled thread
| Started by | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| First post | 2016-05-06 19:30 +0200 |
| Last post | 2016-05-07 04:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure Dan Williams <dan.j.williams@intel.com> - 2016-05-06 19:30 +0200
Re: [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure Guenter Roeck <linux@roeck-us.net> - 2016-05-07 04:30 +0200
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Date | 2016-05-06 19:30 +0200 |
| Subject | [PATCH] libnvdimm, pfn: fix ARCH=alpha allmodconfig build failure |
| Message-ID | <rvRJD-YG-1@gated-at.bofh.it> |
I had relied on the kbuild robot for cross build coverage, however it
only builds alpha_defconfig. Switch from HPAGE_SIZE to PMD_SIZE, which
is more widely defined.
Fixes: 658922e57b84 ("libnvdimm, pfn: fix memmap reservation sizing")
Cc: <stable@vger.kernel.org>
Reported-by: Guenter Roeck <guenter@roeck-us.net>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/nvdimm/pmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index 5101f3ab4f29..e5a8bf032ec9 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -404,7 +404,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn)
* vmemmap_populate_hugepages() allocates the memmap array in
* HPAGE_SIZE chunks.
*/
- memmap_size = ALIGN(64 * npfns, HPAGE_SIZE);
+ memmap_size = ALIGN(64 * npfns, PMD_SIZE);
offset = ALIGN(start + SZ_8K + memmap_size, nd_pfn->align)
- start;
} else if (nd_pfn->mode == PFN_MODE_RAM)
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2016-05-07 04:30 +0200 |
| Message-ID | <rw0ad-1fb-1@gated-at.bofh.it> |
| In reply to | #1395994 |
On 05/06/2016 10:26 AM, Dan Williams wrote:
> I had relied on the kbuild robot for cross build coverage, however it
> only builds alpha_defconfig. Switch from HPAGE_SIZE to PMD_SIZE, which
> is more widely defined.
>
> Fixes: 658922e57b84 ("libnvdimm, pfn: fix memmap reservation sizing")
> Cc: <stable@vger.kernel.org>
> Reported-by: Guenter Roeck <guenter@roeck-us.net>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Passes at least all my tests.
Tested-by: Guenter Roeck <linux@roeck-us.net>
Nitpick below.
> ---
> drivers/nvdimm/pmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 5101f3ab4f29..e5a8bf032ec9 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -404,7 +404,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn)
> * vmemmap_populate_hugepages() allocates the memmap array in
> * HPAGE_SIZE chunks.
PMD_SIZE
> */
> - memmap_size = ALIGN(64 * npfns, HPAGE_SIZE);
> + memmap_size = ALIGN(64 * npfns, PMD_SIZE);
> offset = ALIGN(start + SZ_8K + memmap_size, nd_pfn->align)
> - start;
> } else if (nd_pfn->mode == PFN_MODE_RAM)
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web