Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395262
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] kbuild: fix if_change and friends to consider argument order |
| Date | 2016-05-05 20:10 +0200 |
| Message-ID | <rvvSO-4Pl-3@gated-at.bofh.it> (permalink) |
| References | <rvmcO-3Ju-7@gated-at.bofh.it> <rvmwa-4mY-1@gated-at.bofh.it> <rvsUW-1Mr-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2016-05-05 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>: > 2016-05-05 17:08 GMT+09:00 Woodhouse, David <david.woodhouse@intel.com>: >> On Thu, 2016-05-05 at 16:45 +0900, Masahiro Yamada wrote: >>> >>> This commit fixes arg-check to compare two strings as a whole. >>> $(strip ...) is important because we want to ignore the difference >>> that comes from white-spaces. >> >> Do we? >> >> I can construct a hypothetical situation in which whitespace differs >> and we *do* want it to make a difference (for example I used to sign >> with a key called 'My Signing Key.pem' and now I've changed to use >> 'My Signing Key.pem'. (OK, it's a *stupid* example but still...) >> >> I couldn't come up with the converse — where whitespace does change for >> some reason, but we really don't want to rebuild. >> >> Should we err on the side of caution, and let whitespace changes >> trigger a rebuild? >> >> -- >> David Woodhouse Open Source Technology Centre >> David.Woodhouse@intel.com Intel Corporation >> > > > > Please hold on. > > I noticed some side effect on this patch. > > I need to test it more carefully. This patch is not working at all. Please disregard it. Probably, I will send v2 in a few days. -- Best Regards Masahiro Yamada
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-05 09:50 +0200
Re: [PATCH] kbuild: fix if_change and friends to consider argument order "Woodhouse, David" <david.woodhouse@intel.com> - 2016-05-05 10:10 +0200
Re: [PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-05 17:00 +0200
Re: [PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-05 20:10 +0200
Re: [PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-06 04:20 +0200
csiph-web