Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1394918

Re: [PATCH] kbuild: fix if_change and friends to consider argument order

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, 2016-05-05 at 16:45 +0900, Masahiro Yamada wrote:
> 
> This commit fixes arg-check to compare two strings as a whole.
> $(strip ...) is important because we want to ignore the difference
> that comes from white-spaces.

Do we?

I can construct a hypothetical situation in which whitespace differs
and we *do* want it to make a difference (for example I used to sign
with a key called 'My Signing Key.pem' and now I've changed to use
'My  Signing  Key.pem'. (OK, it's a *stupid* example but still...)

I couldn't come up with the converse — where whitespace does change for
some reason, but we really don't want to rebuild.

Should we err on the side of caution, and let whitespace changes
trigger a rebuild?

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-05 09:50 +0200
  Re: [PATCH] kbuild: fix if_change and friends to consider argument  order "Woodhouse, David" <david.woodhouse@intel.com> - 2016-05-05 10:10 +0200
    Re: [PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-05 17:00 +0200
      Re: [PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-05 20:10 +0200
    Re: [PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-05-06 04:20 +0200

csiph-web