Re: [v4.6-rc1 Regression] x86/topology: Create logical package id

From	Joseph Salisbury <joseph.salisbury@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [v4.6-rc1 Regression] x86/topology: Create logical package id
Date	2016-05-06 23:00 +0200
Message-ID	<rvV0S-3D7-5@gated-at.bofh.it> (permalink)
References	<rvSw3-1EJ-39@gated-at.bofh.it> <rvT8K-20P-11@gated-at.bofh.it> <rvTLs-2Ip-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/06/2016 03:38 PM, Joseph Salisbury wrote:
> On 05/06/2016 02:48 PM, Thomas Gleixner wrote:
>> On Fri, 6 May 2016, Joseph Salisbury wrote:
>>> A kernel bug report was opened against Ubuntu [0].  After a kernel
>>> bisect, it was found that reverting the following commit resolved this bug:
>>>
>>> commit 1f12e32f4cd5243ae46d8b933181be0d022c6793
>>> Author: Thomas Gleixner <tglx@linutronix.de>
>>> Date:   Mon Feb 22 22:19:15 2016 +0000
>>>
>>>     x86/topology: Create logical package id
>>>
>>> To build successfully with this commit reverted, I also had to revert
>>> commits: e7ee3e8,2d4de83,87f01cc and 33c3cc7.
>>>
>>> The regression was introduced as of v4.6-rc1.
>>>     
>>> I was hoping to get your feedback, since you are the patch author.  Do
>>> you think gathering any additional data will help diagnose this issue,
>>> or would it be best to submit a revert request?
>> Yuck. That dies with a divide error. And that looks like XEN is supplying crap
>> data in the CPUID.
>>
>> Does the patch below cure the issue?
>>
>> Thanks,
>>
>>         tglx
>>
>> 8<---------------
>>
>> --- a/arch/x86/kernel/smpboot.c
>> +++ b/arch/x86/kernel/smpboot.c
>> @@ -332,6 +332,11 @@ static void __init smp_init_package_map(
>>  	 * primary cores.
>>  	 */
>>  	ncpus = boot_cpu_data.x86_max_cores;
>> +	if (!ncpus) {
>> +		pr_warn("x86_max_cores == zero !?!?");
>> +		ncpus = 1;
>> +	}
>> +
>>  	__max_logical_packages = DIV_ROUND_UP(total_cpus, ncpus);
>>  
>>  	/*
> I'll have this patch tested and report back.
>
> Thanks,
>
> Joe
Yes, your patch does in fact fix the bug.  Would you like any additional
information regarding the bug?

Thread

[v4.6-rc1 Regression] x86/topology: Create logical package id Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-05-06 20:20 +0200
  Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Thomas Gleixner <tglx@linutronix.de> - 2016-05-06 21:00 +0200
    Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-05-06 21:20 +0200
      Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-05-06 21:40 +0200
        Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-05-06 22:50 +0200
          Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-05-06 23:00 +0200
            Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-05-06 23:30 +0200
    Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-05-06 21:40 +0200
      Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Joseph Salisbury <joseph.salisbury@canonical.com> - 2016-05-06 23:00 +0200
    Re: [v4.6-rc1 Regression] x86/topology: Create logical package id Ingo Molnar <mingo@kernel.org> - 2016-05-07 07:20 +0200
    [tip:x86/urgent] x86/topology: Handle CPUID bogosity gracefully tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-05-07 10:20 +0200

csiph-web