Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1395711

[PATCH] perf/x86/intel/uncore: Fix CHA registers configuration procedure for Knights Landing platform

Show all headers | View raw

CHA events in Knights Landing platform require programming filter registers properly.
Before change, code lacked mandatory bitset operations for reserved bits.
As a result some events were not counted.

Fixes: 77af003 ('perf/x86/intel/uncore: Add Knights Landing uncore PMU support')
Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
Signed-off-by: Lawrence F Meadows <lawrence.f.meadows@intel.com>
---
 arch/x86/events/intel/uncore_snbep.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
index ab2bcaa..47d7216 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -1902,6 +1902,7 @@ static int knl_cha_hw_config(struct intel_uncore_box *box,
 		reg1->reg = HSWEP_C0_MSR_PMON_BOX_FILTER0 +
 			    KNL_CHA_MSR_OFFSET * box->pmu->pmu_idx;
 		reg1->config = event->attr.config1 & knl_cha_filter_mask(idx);
+		reg1->config |= 0x23ull << 32;
 		reg1->idx = idx;
 	}
 	return 0;
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf/x86/intel/uncore: Fix CHA registers configuration procedure for Knights Landing platform hchrzani <hubert.chrzaniuk@intel.com> - 2016-05-06 11:00 +0200
  Re: [PATCH] perf/x86/intel/uncore: Fix CHA registers configuration  procedure for Knights Landing platform Thomas Gleixner <tglx@linutronix.de> - 2016-05-06 12:00 +0200
    [PATCH] perf/x86/intel/uncore: Fix CHA registers configuration procedure for Knights Landing platform hchrzani <hubert.chrzaniuk@intel.com> - 2016-05-06 15:30 +0200
      Re: [PATCH] perf/x86/intel/uncore: Fix CHA registers configuration  procedure for Knights Landing platform Ingo Molnar <mingo@kernel.org> - 2016-05-07 07:50 +0200
        [PATCH v3] perf/x86/intel/uncore: Fix CHA registers configuration Hubert Chrzaniuk <hubert.chrzaniuk@intel.com> - 2016-05-09 10:00 +0200
          [PATCH] perf/x86/intel/uncore: Fix CHA registers configuration procedure for Knights Landing platform Hubert Chrzaniuk <hubert.chrzaniuk@intel.com> - 2016-05-09 10:00 +0200
            [tip:perf/core] perf/x86/intel/uncore: Fix CHA registers  configuration procedure for Knights Landing platform tip-bot for hchrzani <tipbot@zytor.com> - 2016-05-12 12:40 +0200

csiph-web