Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Keerthy <a0393675@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators
Date	Fri, 06 May 2016 06:50:01 +0200
Message-ID	<rvFS9-6PL-3@gated-at.bofh.it> (permalink)
References	<rvjRE-1Ry-7@gated-at.bofh.it> <rvjRE-1Ry-11@gated-at.bofh.it> <rvtxE-2sD-21@gated-at.bofh.it>
X-Original-To	Mark Brown <broonie@kernel.org>, Keerthy <j-keerthy@ti.com>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	<lgirdwood@gmail.com>, <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>, <robh+dt@kernel.org>, <mark.rutland@arm.com>
X-Original-Date	Fri, 6 May 2016 10:13:24 +0530
X-Original-Message-ID	<572C20EC.7000706@ti.com>
X-Original-References	<1462425040-18566-1-git-send-email-j-keerthy@ti.com> <1462425040-18566-4-git-send-email-j-keerthy@ti.com> <20160505153820.GF6292@sirena.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1395600

Show key headers only | View raw

Hi Mark,

On Thursday 05 May 2016 09:08 PM, Mark Brown wrote:
> On Thu, May 05, 2016 at 10:40:40AM +0530, Keerthy wrote:
>
>> +static const struct of_device_id of_lp873x_match_tbl[] = {
>> +	{ .compatible = "ti,lp8733-regulators",},
>> +	{ .compatible = "ti,lp8732-regulators",},
>> +	{ .compatible = "ti,lp873x-regulators",},
>> +	{},
>> +};
>
> There should be no need for compatible strings here, we already know
> what device this is from the parent.  The way we split drivers up for
> Linux is something that's internal to Linux and shouldn't be in the
> device tree.  If we do have explicit compatible strings then they should
> (as always) be specific to a device, no wildcards.

Thanks for the review.

I am using of_platform_populate function in the mfd driver to create 
platform devices for the child nodes, in my case regulators.

of_platform_populate in turn calls on to of_platform_bus_create which 
mandates compatible properties. It quietly skips device creation if 
there are no compatible properties.

When i enabled a debug print, i see this:
skipping /ocp/i2c@48070000/lp8732@61/regulators, no compatible prop
Hence i kept the compatible properties.

The driver supports two variants of LP873x family:

1) LP8732
2) LP8733

I will knock off the ti,lp873x-regulators compatible which is more 
generic/wildcard entry.

Let me know if this approach is fine.

>
> Otherwise this looks sensible.
>

Thread

[PATCH 0/3] mfd: lp873x: Add lp873x PMIC support Keerthy <j-keerthy@ti.com> - 2016-05-05 07:20 +0200
  [PATCH] mfd: lp873x: Add lp873x PMIC support Keerthy <j-keerthy@ti.com> - 2016-05-05 07:20 +0200
    Re: [PATCH] mfd: lp873x: Add lp873x PMIC support Manish Badarkhe <badarkhe.manish@gmail.com> - 2016-05-05 10:40 +0200
      Re: [PATCH] mfd: lp873x: Add lp873x PMIC support Keerthy <a0393675@ti.com> - 2016-05-06 06:10 +0200
  [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC regulators Keerthy <j-keerthy@ti.com> - 2016-05-05 07:20 +0200
    Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC  regulators Mark Brown <broonie@kernel.org> - 2016-05-05 17:40 +0200
      Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC  regulators Keerthy <a0393675@ti.com> - 2016-05-06 06:50 +0200
        Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC  regulators Mark Brown <broonie@kernel.org> - 2016-05-06 14:10 +0200
          Re: [PATCH 3/3] regulator: lp873x: Add support for lp873x PMIC  regulators Keerthy <a0393675@ti.com> - 2016-05-06 14:40 +0200

csiph-web