Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1395561
| From | Yinghai Lu <yinghai@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource |
| Date | 2016-05-06 03:00 +0200 |
| Message-ID | <rvChA-2DB-7@gated-at.bofh.it> (permalink) |
| References | (10 earlier) <rv6KK-6s5-25@gated-at.bofh.it> <rva1Y-TX-7@gated-at.bofh.it> <rvfkZ-60t-5@gated-at.bofh.it> <rvtR0-2Dm-7@gated-at.bofh.it> <rvzD4-9z-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, May 5, 2016 at 3:02 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Thu, 2016-05-05 at 08:53 -0700, Yinghai Lu wrote:
>> For powerpc io port, we still need extra offset from resource address
>> to final address.
>>
>> resource_size_t offset =
>> ((resource_size_t)vma->vm_pgoff) << PAGE_SHIFT;
>>
>> + if (mmap_state == pci_mmap_io) {
>> + struct pci_controller *hose = pci_bus_to_host(dev->bus);
>> +
>> + /* hose should never be NULL */
>> + offset += hose->io_base_phys -
>> + ((unsigned long)hose->io_base_virt - _IO_BASE);
>> + }
>>
>> vma->vm_pgoff = offset >> PAGE_SHIFT;
>>
>> but sparc does not need that trick.
>
> I'm not sure how sparc handles IO space but on powerpc, the IO resource
> is not a physical address, it's a virtual address (coming from
> ioremap).
That is interesting. Any reason for that ?
why just cpu_addr in resource directly ?
Thanks
Yinghai
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Bjorn Helgaas <helgaas@kernel.org> - 2016-04-28 16:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-04-29 09:20 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-04 01:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-05-04 02:40 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Bjorn Helgaas <helgaas@kernel.org> - 2016-05-04 03:30 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-04 07:10 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-04 08:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Bjorn Helgaas <helgaas@kernel.org> - 2016-05-04 17:20 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-04 20:50 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-05 02:30 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-05 18:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-05-06 00:10 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-06 03:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-06 06:20 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Bjorn Helgaas <helgaas@kernel.org> - 2016-05-06 20:30 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-10 08:20 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource David Miller <davem@davemloft.net> - 2016-05-04 06:20 +0200
csiph-web