Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1393885
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource |
| Date | 2016-05-04 03:30 +0200 |
| Message-ID | <ruTNv-2ke-1@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <rsMds-5yO-3@gated-at.bofh.it> <rsUE4-41Z-21@gated-at.bofh.it> <rtaSu-1U4-21@gated-at.bofh.it> <ruRsm-dq-9@gated-at.bofh.it> <ruT17-1Cp-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, May 04, 2016 at 10:37:40AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2016-05-03 at 15:52 -0700, Yinghai Lu wrote:
> > BenH and DavidM,
> > Are you ok to let /proc/bus/pci/devices to expose resource value
> > instead of
> > BAR value?
> > powerpc already expose MMIO as resource value, but still keep IO as
> > BAR value?
> >
> > Or can we just dump /proc/bus/pci support from now?
>
> The problem tends to be old Xserver expectations...
>
> That stuff has been a can of worms over the years and we did things in
> the kernel to work around X limitations. I'm not that keen on touching
> /proc at all in that regard. Leave it there do what it does today, it's
> a user visible ABI, don't change it.
I did not propose changing any user-visible ABI. To recap what I did
propose:
- The sysfs path uses offsets between 0 and BAR size on all arches.
It uses pci_resource_to_user() today, but I think it should not.
- The procfs path uses offsets of resource values (CPU physical
addresses) on most architectures, but uses something else, e.g.,
BAR values, on others. pci_resource_to_user() does this
translation. The procfs path does not use pci_resource_to_user()
today, but I think it should.
- This implies that pci_mmap_page_range() should deal with resource
values (CPU physical addresses), and proc_bus_pci_mmap() should do
any necessary arch-specific translation from BAR values to
resource values.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Bjorn Helgaas <helgaas@kernel.org> - 2016-04-28 16:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-04-29 09:20 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-04 01:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-05-04 02:40 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Bjorn Helgaas <helgaas@kernel.org> - 2016-05-04 03:30 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-04 07:10 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-04 08:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Bjorn Helgaas <helgaas@kernel.org> - 2016-05-04 17:20 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-04 20:50 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-05 02:30 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-05 18:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-05-06 00:10 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-06 03:00 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-06 06:20 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Bjorn Helgaas <helgaas@kernel.org> - 2016-05-06 20:30 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource Yinghai Lu <yinghai@kernel.org> - 2016-05-10 08:20 +0200
Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource David Miller <davem@davemloft.net> - 2016-05-04 06:20 +0200
csiph-web