[PATCH] fix infoleak in wireless

From	Kangjie Lu <kangjielu@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] fix infoleak in wireless
Date	2016-05-03 22:40 +0200
Message-ID	<ruPgS-6BH-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The 6-bytes array “mac_addr” is not initialized in the dump_station
implementations of “drivers/staging/wilc1000/wilc_wfi_cfgoperations.c”
and “drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c”, so all 6
bytes may be leaked.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
 net/wireless/nl80211.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 056a730..2e92d14 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -3905,6 +3905,7 @@ static int nl80211_dump_station(struct sk_buff *skb,
 
 	while (1) {
 		memset(&sinfo, 0, sizeof(sinfo));
+		eth_zero_addr(mac_addr);
 		err = rdev_dump_station(rdev, wdev->netdev, sta_idx,
 					mac_addr, &sinfo);
 		if (err == -ENOENT)
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] fix infoleak in wireless Kangjie Lu <kangjielu@gmail.com> - 2016-05-03 22:40 +0200
  Re: [PATCH] fix infoleak in wireless Johannes Berg <johannes@sipsolutions.net> - 2016-05-03 22:50 +0200
    Re: [PATCH] fix infoleak in wireless Greg Kroah-Hartman <greg@kroah.com> - 2016-05-03 23:10 +0200
      Re: [PATCH] fix infoleak in wireless Greg Kroah-Hartman <greg@kroah.com> - 2016-05-03 23:40 +0200
        Re: [PATCH] fix infoleak in wireless Greg Kroah-Hartman <greg@kroah.com> - 2016-05-03 23:50 +0200

csiph-web