[PATCH] fix infoleak in fcntl

From	Kangjie Lu <kangjielu@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] fix infoleak in fcntl
Date	2016-05-03 22:40 +0200
Message-ID	<ruPgS-6BH-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The stack object “si” has a total size of 128 bytes; however, only
16 bytes are initialized. The remaining uninitialized bytes are
sent to userland via send_signal.

Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
 fs/fcntl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/fcntl.c b/fs/fcntl.c
index 350a2c8..d06f943 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -468,6 +468,7 @@ static void send_sigio_to_task(struct task_struct *p,
 			   delivered even if we can't queue.  Failure to
 			   queue in this case _should_ be reported; we fall
 			   back to SIGIO in that case. --sct */
+			memset(&si, 0, sizeof(si));
 			si.si_signo = signum;
 			si.si_errno = 0;
 		        si.si_code  = reason;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] fix infoleak in fcntl Kangjie Lu <kangjielu@gmail.com> - 2016-05-03 22:40 +0200
  Re: [PATCH] fix infoleak in fcntl Christoph Hellwig <hch@infradead.org> - 2016-05-08 12:50 +0200
  Re: [PATCH] fix infoleak in fcntl Richard Weinberger <richard.weinberger@gmail.com> - 2016-05-08 15:00 +0200

csiph-web