Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1393352

Re: [PATCH v2] rtc: stmp3xxx: print message on error

From Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] rtc: stmp3xxx: print message on error
Date 2016-05-03 13:50 +0200
Message-ID <ruGZZ-7ro-9@gated-at.bofh.it> (permalink)
References <rtIAN-4s0-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 30/04/2016 at 20:11:30 +0100, Sudip Mukherjee wrote :
> stmp3xxx_wdt_register() can fail as platform_device_alloc() or
> platform_device_add() can fail. But when it fails it failed silently.
> Lets print out an error message on failure so that user will atlest
> know that there was some error.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> 
> v1 -  returned error while failing in the probe.
> 
>  drivers/rtc/rtc-stmp3xxx.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v2] rtc: stmp3xxx: print message on error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-30 21:20 +0200
  Re: [PATCH v2] rtc: stmp3xxx: print message on error Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-05-03 13:50 +0200

csiph-web