Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1393351
| From | Jon Hunter <jonathanh@nvidia.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/6] soc/tegra: pmc: Correct type of variable for tegra_pmc_readl() |
| Date | 2016-05-03 13:50 +0200 |
| Message-ID | <ruGZZ-7ro-7@gated-at.bofh.it> (permalink) |
| References | <ruliO-3kM-17@gated-at.bofh.it> <ruliP-3kM-51@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/05/16 13:17, Laxman Dewangan wrote:
> The function tegra_pmc_readl() returns the u32 type data and hence
> change the data type of variable where this data is stored to u32
> type.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>
> ---
> Changes from V1:
> -This is new in series as per discussion on V1 series to use u32 for
> tegra_pmc_readl.
> ---
> drivers/soc/tegra/pmc.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 2c3f1f9..fc4f7b2 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -878,7 +878,7 @@ static int tegra_io_rail_prepare(unsigned int id, unsigned long *request,
> static int tegra_io_rail_poll(unsigned long offset, unsigned long mask,
> unsigned long val, unsigned long timeout)
> {
> - unsigned long value;
> + u32 value;
You also need to make mask and val a u32.
Jon
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] soc/tegra: Add support for IO pads control via pinctrl interface Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-02 14:40 +0200
[PATCH 4/6] soc/tegra: pmc: Register PMC child devices as platform device Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-02 14:40 +0200
Re: [PATCH 4/6] soc/tegra: pmc: Register PMC child devices as platform device Jon Hunter <jonathanh@nvidia.com> - 2016-05-03 14:40 +0200
Re: [PATCH 4/6] soc/tegra: pmc: Register PMC child devices as platform device Jon Hunter <jonathanh@nvidia.com> - 2016-05-03 17:30 +0200
[PATCH 1/6] soc/tegra: pmc: Use BIT macro for register field definition Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-02 14:40 +0200
[PATCH 2/6] soc/tegra: pmc: Correct type of variable for tegra_pmc_readl() Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-02 14:40 +0200
Re: [PATCH 2/6] soc/tegra: pmc: Correct type of variable for tegra_pmc_readl() Jon Hunter <jonathanh@nvidia.com> - 2016-05-03 13:50 +0200
Re: [PATCH 0/6] soc/tegra: Add support for IO pads control via pinctrl interface Jon Hunter <jonathanh@nvidia.com> - 2016-05-03 13:40 +0200
csiph-web