Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1391419

[PATCH 3/3] xfs: Add alignment check for DAX mount

Show all headers | View raw

When a partition is not aligned by 4KB, mount -o dax succeeds,
but any read/write access to the filesystem fails, except for
metadata update.

Add alignment check to xfs_fs_fill_super() when -o dax is
specified.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Dave Chinner <david@fromorbit.com> (supporter:XFS FILESYSTEM)
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
---
 fs/xfs/xfs_super.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 187e14b..a17aebc 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1563,6 +1563,11 @@ xfs_fs_fill_super(
 			xfs_alert(mp,
 		"Filesystem block size invalid for DAX Turning DAX off.");
 			mp->m_flags &= ~XFS_MOUNT_DAX;
+		} else if (sb->s_bdev->bd_part->start_sect % (PAGE_SIZE / 512)
+		   || sb->s_bdev->bd_part->nr_sects % (PAGE_SIZE / 512)) {
+			xfs_alert(mp,
+		"Partition alignment invalid for DAX Turning DAX off.");
+			mp->m_flags &= ~XFS_MOUNT_DAX;
 		} else if (!sb->s_bdev->bd_disk->fops->direct_access) {
 			xfs_alert(mp,
 		"Block device does not support DAX Turning DAX off.");

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-04-29 22:50 +0200
  [PATCH 1/3] ext4: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-04-29 22:50 +0200
    Re: [PATCH 1/3] ext4: Add alignment check for DAX mount Boaz Harrosh <boaz@plexistor.com> - 2016-05-01 11:40 +0200
    Re: [PATCH 1/3] ext4: Add alignment check for DAX mount Christoph Hellwig <hch@infradead.org> - 2016-05-01 19:40 +0200
      Re: [PATCH 1/3] ext4: Add alignment check for DAX mount Boaz Harrosh <boaz@plexistor.com> - 2016-05-02 11:50 +0200
        Re: [PATCH 1/3] ext4: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-05-02 17:40 +0200
  [PATCH 3/3] xfs: Add alignment check for DAX mount Toshi Kani <toshi.kani@hpe.com> - 2016-04-29 22:50 +0200
  Re: [PATCH 0/3] Add alignment check for DAX mount Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-04-30 01:20 +0200

csiph-web