Re: [PATCH] tpm: select ANON_INODES for proxy driver

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tpm: select ANON_INODES for proxy driver
Date	Fri, 29 Apr 2016 21:50:01 +0200
Message-ID	<rtmAh-38J-3@gated-at.bofh.it> (permalink)
References	<rsRGa-1DA-27@gated-at.bofh.it> <rtlEe-2fj-13@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.24,553,1455004800"; d="scan'208";a="955745765"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
X-Original-Cc	Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 29 Apr 2016 22:41:38 +0300
X-Original-Message-ID	<20160429194138.GA22950@intel.com>
X-Original-References	<1461840382-2996256-1-git-send-email-arnd@arndb.de> <20160429184206.GA21071@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1391367

Show key headers only | View raw

On Fri, Apr 29, 2016 at 09:42:06PM +0300, Jarkko Sakkinen wrote:
> On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote:
> > The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> > is disabled:
> > 
> > drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> > (.text+0x97f8): undefined reference to `anon_inode_getfile'
> > 
> > This adds a Kconfig 'select' statement to ensure it's always there
> > when we need it.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
> 
> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> /Jarkko

Applied and merge to next.

/Jarkko

> > ---
> >  drivers/char/tpm/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> > index 0eac596e33d1..bfdc5c0486aa 100644
> > --- a/drivers/char/tpm/Kconfig
> > +++ b/drivers/char/tpm/Kconfig
> > @@ -125,6 +125,7 @@ config TCG_CRB
> >  config TCG_VTPM_PROXY
> >  	tristate "VTPM Proxy Interface"
> >  	depends on TCG_TPM
> > +	select ANON_INODES
> >  	---help---
> >  	  This driver proxies for an emulated TPM (vTPM) running in userspace.
> >  	  A device /dev/vtpmx is provided that creates a device pair
> > -- 
> > 2.7.0
> >

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: select ANON_INODES for proxy driver Arnd Bergmann <arnd@arndb.de> - 2016-04-28 12:50 +0200
  Re: [PATCH] tpm: select ANON_INODES for proxy driver Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-28 13:00 +0200
  Re: [PATCH] tpm: select ANON_INODES for proxy driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-29 20:50 +0200
    Re: [PATCH] tpm: select ANON_INODES for proxy driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-29 21:50 +0200

csiph-web