Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1390027 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-04-28 12:50 +0200 |
| Last post | 2016-04-29 21:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] tpm: select ANON_INODES for proxy driver Arnd Bergmann <arnd@arndb.de> - 2016-04-28 12:50 +0200
Re: [PATCH] tpm: select ANON_INODES for proxy driver Stefan Berger <stefanb@linux.vnet.ibm.com> - 2016-04-28 13:00 +0200
Re: [PATCH] tpm: select ANON_INODES for proxy driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-29 20:50 +0200
Re: [PATCH] tpm: select ANON_INODES for proxy driver Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-04-29 21:50 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-04-28 12:50 +0200 |
| Subject | [PATCH] tpm: select ANON_INODES for proxy driver |
| Message-ID | <rsRGa-1DA-27@gated-at.bofh.it> |
The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
is disabled:
drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
(.text+0x97f8): undefined reference to `anon_inode_getfile'
This adds a Kconfig 'select' statement to ensure it's always there
when we need it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
---
drivers/char/tpm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 0eac596e33d1..bfdc5c0486aa 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -125,6 +125,7 @@ config TCG_CRB
config TCG_VTPM_PROXY
tristate "VTPM Proxy Interface"
depends on TCG_TPM
+ select ANON_INODES
---help---
This driver proxies for an emulated TPM (vTPM) running in userspace.
A device /dev/vtpmx is provided that creates a device pair
--
2.7.0
[toc] | [next] | [standalone]
| From | Stefan Berger <stefanb@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-04-28 13:00 +0200 |
| Message-ID | <rsRPQ-1Hf-7@gated-at.bofh.it> |
| In reply to | #1390027 |
On 04/28/2016 06:46 AM, Arnd Bergmann wrote:
> The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> is disabled:
>
> drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> (.text+0x97f8): undefined reference to `anon_inode_getfile'
>
> This adds a Kconfig 'select' statement to ensure it's always there
> when we need it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
Acked-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Thanks.
[toc] | [prev] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2016-04-29 20:50 +0200 |
| Message-ID | <rtlEe-2fj-13@gated-at.bofh.it> |
| In reply to | #1390027 |
On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote:
> The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> is disabled:
>
> drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> (.text+0x97f8): undefined reference to `anon_inode_getfile'
>
> This adds a Kconfig 'select' statement to ensure it's always there
> when we need it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 0eac596e33d1..bfdc5c0486aa 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -125,6 +125,7 @@ config TCG_CRB
> config TCG_VTPM_PROXY
> tristate "VTPM Proxy Interface"
> depends on TCG_TPM
> + select ANON_INODES
> ---help---
> This driver proxies for an emulated TPM (vTPM) running in userspace.
> A device /dev/vtpmx is provided that creates a device pair
> --
> 2.7.0
>
[toc] | [prev] | [next] | [standalone]
| From | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> |
|---|---|
| Date | 2016-04-29 21:50 +0200 |
| Message-ID | <rtmAh-38J-3@gated-at.bofh.it> |
| In reply to | #1391328 |
On Fri, Apr 29, 2016 at 09:42:06PM +0300, Jarkko Sakkinen wrote:
> On Thu, Apr 28, 2016 at 12:46:13PM +0200, Arnd Bergmann wrote:
> > The newly added vtpmx driver fails to build if CONFIG_ANON_INODES
> > is disabled:
> >
> > drivers/char/built-in.o: In function `vtpmx_fops_ioctl':
> > (.text+0x97f8): undefined reference to `anon_inode_getfile'
> >
> > This adds a Kconfig 'select' statement to ensure it's always there
> > when we need it.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 794c38e01358 ("tpm: Proxy driver for supporting multiple emulated TPMs")
>
> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> /Jarkko
Applied and merge to next.
/Jarkko
> > ---
> > drivers/char/tpm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> > index 0eac596e33d1..bfdc5c0486aa 100644
> > --- a/drivers/char/tpm/Kconfig
> > +++ b/drivers/char/tpm/Kconfig
> > @@ -125,6 +125,7 @@ config TCG_CRB
> > config TCG_VTPM_PROXY
> > tristate "VTPM Proxy Interface"
> > depends on TCG_TPM
> > + select ANON_INODES
> > ---help---
> > This driver proxies for an emulated TPM (vTPM) running in userspace.
> > A device /dev/vtpmx is provided that creates a device pair
> > --
> > 2.7.0
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web