Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1391333

Re: [PATCH 17/20] dm: get rid of superfluous gfp flags

From Mike Snitzer <snitzer@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 17/20] dm: get rid of superfluous gfp flags
Date 2016-04-29 21:00 +0200
Message-ID <rtlNU-2iW-7@gated-at.bofh.it> (permalink)
References <rsUaZ-3LP-3@gated-at.bofh.it> <rsUb1-3LP-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Apr 28 2016 at  9:24am -0400,
Michal Hocko <mhocko@kernel.org> wrote:

> From: Michal Hocko <mhocko@suse.com>
> 
> copy_params seems to be little bit confused about which allocation flags
> to use. It enforces GFP_NOIO even though it uses
> memalloc_noio_{save,restore} which enforces GFP_NOIO at the page
> allocator level automatically (via memalloc_noio_flags). It also
> uses __GFP_REPEAT for the __vmalloc request which doesn't make much
> sense either because vmalloc doesn't rely on costly high order
> allocations. Let's just drop the __GFP_REPEAT and leave the further
> cleanup to later changes.
> 
> Cc: Shaohua Li <shli@kernel.org>
> Cc: Mikulas Patocka <mpatocka@redhat.com>
> Cc: dm-devel@redhat.com
> Signed-off-by: Michal Hocko <mhocko@suse.com>

I've taken this patch for 4.7 but editted the header, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.7&id=0222c76e96163355620224625c1cd80991086dc7

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 17/20] dm: get rid of superfluous gfp flags Michal Hocko <mhocko@kernel.org> - 2016-04-28 15:30 +0200
  Re: [PATCH 17/20] dm: get rid of superfluous gfp flags Mike Snitzer <snitzer@redhat.com> - 2016-04-29 21:00 +0200
    Re: [PATCH 17/20] dm: get rid of superfluous gfp flags Michal Hocko <mhocko@kernel.org> - 2016-05-02 09:40 +0200

csiph-web