Re: [PATCH] sched/core: don't include asm/mmu_context from drivers

From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched/core: don't include asm/mmu_context from drivers
Date	2016-04-29 21:00 +0200
Message-ID	<rtlNU-2iW-5@gated-at.bofh.it> (permalink)
References	<rtcrg-2XJ-5@gated-at.bofh.it> <rtgXV-6T4-23@gated-at.bofh.it> <rtiGl-8rB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 29, 2016 at 8:37 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 29 April 2016 09:42:18 Steven Rostedt wrote:
>> On Fri, 29 Apr 2016 10:52:32 +0200
>> Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> > This reverts the earlier fix attempt and works around the problem
>> > by including both linux/mmu_context.h and asm/mmu_context.h from
>> > kernel/sched/core.c. This is not a good solution but seems less
>> > hacky than the alternatives.
>>
>> What about simply not compiling finish_arch_post_lock_switch() when
>> building modules?
>>
>> (untested, not compiled or anything)
>>
>> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>>
>
> It should work as well.
>
> I think I suggested doing that the last time the problem came up
> a few years ago, but we ended up not including the header instead,
> so I kept doing that.
>
>         Arnd

This variant looks considerably nicer to me.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sched/core: don't include asm/mmu_context from drivers Arnd Bergmann <arnd@arndb.de> - 2016-04-29 11:00 +0200
  Re: [PATCH] sched/core: don't include asm/mmu_context from drivers Steven Rostedt <rostedt@goodmis.org> - 2016-04-29 15:50 +0200
    Re: [PATCH] sched/core: don't include asm/mmu_context from drivers Arnd Bergmann <arnd@arndb.de> - 2016-04-29 17:40 +0200
      Re: [PATCH] sched/core: don't include asm/mmu_context from drivers Andy Lutomirski <luto@amacapital.net> - 2016-04-29 21:00 +0200

csiph-web