Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1391071
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] net: macb: do not scan PHYs manually |
| Date | 2016-04-29 14:50 +0200 |
| Message-ID | <rtg1R-657-15@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <rsZkn-mr-19@gated-at.bofh.it> <rt1ma-2o0-3@gated-at.bofh.it> <rt1Fw-2Aw-17@gated-at.bofh.it> <rt4Dn-52y-1@gated-at.bofh.it> <rtfIt-5Wt-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index eec3200..d843bc9 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -419,11 +419,62 @@ static int macb_mii_probe(struct net_device *dev)
> return 0;
> }
>
> +static int macb_mii_of_init(struct macb *bp, struct device_node *np)
> +{
> + struct device_node *mdio;
> + int err, i;
> +
> + mdio = of_get_child_by_name(np, "mdio");
> + if (mdio)
> + return of_mdiobus_register(bp->mii_bus, mdio);
We want to encourage driver writers to use an mdio subnode inside
there MAC node. So i wounder if this looking for the child and using
it should go into the core code?
Florian: What do you think?
> +
> + dev_warn(&bp->pdev->dev,
> + "using deprecated PHY probing mechanism. Please update device tree.");
> +
> + /* try dt phy registration */
> + err = of_mdiobus_register(bp->mii_bus, np);
> + if (err)
> + return err;
> +
> + /* fallback to standard phy registration if no phy were
> + * found during dt phy registration
> + */
> + if (!phy_find_first(bp->mii_bus)) {
I would also suggest putting a warning here, saying that PHYs should
be listed in the device tree.
> + for (i = 0; i < PHY_MAX_ADDR; i++) {
> + struct phy_device *phydev;
> +
> + phydev = mdiobus_scan(bp->mii_bus, i);
> + if (IS_ERR(phydev)) {
> + err = PTR_ERR(phydev);
FYI: There is a change making its way through which will mean
mdiobus_scan() will return -ENODEV where there is nothing on the bus
at that address, rather than the current NULL. You will need to adopt
this here.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] net: macb: do not scan PHYs manually Nathan Sullivan <nathan.sullivan@ni.com> - 2016-04-28 16:50 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-04-28 17:50 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Nathan Sullivan <nathan.sullivan@ni.com> - 2016-04-28 18:00 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Andrew Lunn <andrew@lunn.ch> - 2016-04-28 18:40 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Nathan Sullivan <nathan.sullivan@ni.com> - 2016-04-28 20:00 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Andrew Lunn <andrew@lunn.ch> - 2016-04-28 20:50 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Nathan Sullivan <nathan.sullivan@ni.com> - 2016-04-28 21:00 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Andrew Lunn <andrew@lunn.ch> - 2016-04-28 21:00 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Florian Fainelli <f.fainelli@gmail.com> - 2016-04-28 22:10 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Andrew Lunn <andrew@lunn.ch> - 2016-04-28 22:20 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Josh Cartwright <joshc@ni.com> - 2016-04-28 23:10 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Andrew Lunn <andrew@lunn.ch> - 2016-04-28 23:30 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Josh Cartwright <joshc@ni.com> - 2016-04-29 02:40 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Josh Cartwright <joshc@ni.com> - 2016-04-29 14:30 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Andrew Lunn <andrew@lunn.ch> - 2016-04-29 14:50 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-04-29 14:50 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Andrew Lunn <andrew@lunn.ch> - 2016-04-29 15:00 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Josh Cartwright <joshc@ni.com> - 2016-05-02 21:00 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Florian Fainelli <f.fainelli@gmail.com> - 2016-05-02 21:10 +0200
Re: [PATCH v2] net: macb: do not scan PHYs manually Josh Cartwright <joshc@ni.com> - 2016-05-02 21:40 +0200
csiph-web