Re: [RFC PATCH 1/4] cpufreq: governor: support scheduler cpufreq callbacks on remote CPUs

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/4] cpufreq: governor: support scheduler cpufreq callbacks on remote CPUs
Date	2016-04-29 12:40 +0200
Message-ID	<rte02-4gY-21@gated-at.bofh.it> (permalink)
References	<rpQdz-yF-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 19-04-16, 19:39, Steve Muckle wrote:
> diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
> index 20f0a4e114d1..429d3a5b9866 100644
> --- a/drivers/cpufreq/cpufreq_governor.c
> +++ b/drivers/cpufreq/cpufreq_governor.c
> @@ -248,6 +248,20 @@ static void dbs_irq_work(struct irq_work *irq_work)
>  	schedule_work_on(smp_processor_id(), &policy_dbs->work);
>  }
>  
> +#ifdef CONFIG_SMP
> +static inline void dbs_irq_work_queue(struct policy_dbs_info *policy_dbs,
> +				      int cpu)
> +{
> +	irq_work_queue_on(&policy_dbs->irq_work, cpu);
> +}
> +#else
> +static inline void dbs_irq_work_queue(struct policy_dbs_info *policy_dbs,
> +				      int cpu)
> +{
> +	irq_work_queue(&policy_dbs->irq_work);
> +}
> +#endif

Any clue, why we don't have a non-SMP version of irq_work_queue_on(), Which can
simply call irq_work_queue() ?

-- 
viresh

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 1/4] cpufreq: governor: support scheduler cpufreq  callbacks on remote CPUs Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-29 12:40 +0200
  Re: [RFC PATCH 1/4] cpufreq: governor: support scheduler cpufreq callbacks on remote CPUs "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-04-29 13:20 +0200
    Re: [RFC PATCH 1/4] cpufreq: governor: support scheduler cpufreq  callbacks on remote CPUs Steve Muckle <steve.muckle@linaro.org> - 2016-05-06 23:00 +0200

csiph-web