Re: [PATCH] mtd: nand: gpmi: get correct free oob space

Path	csiph.com!goblin1!goblin2!goblin.stu.neva.ru!news.karotte.org!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: gpmi: get correct free oob space
Date	Fri, 29 Apr 2016 10:40:02 +0200
Message-ID	<rtc7U-2Py-25@gated-at.bofh.it> (permalink)
References	<rneFs-6vF-13@gated-at.bofh.it> <rnfia-6W5-9@gated-at.bofh.it>
X-Original-To	Han Xu <han.xu@nxp.com>
X-Mailer	Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	<richard@nod.at>, <dwmw2@infradead.org>, <computersforpeace@gmail.com>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 29 Apr 2016 10:31:02 +0200
X-Original-Message-ID	<20160429103102.10ca50f7@bbrezillon>
X-Original-References	<1460498793-19431-1-git-send-email-han.xu@nxp.com> <20160413004351.40064fcd@bbrezillon>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1390868

Show key headers only | View raw

Hi Han,

On Wed, 13 Apr 2016 00:43:51 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> Hi Han,
> 
> On Tue, 12 Apr 2016 17:06:33 -0500
> Han Xu <han.xu@nxp.com> wrote:
> 
> > change the way to calculate pagesize to get correct free oob space for
> > legacy_set_geometry function.  
> 
> Are you sure it's safe to expose free OOB bytes in this case? Do you
> know why it wasn't done before?

You did not answer this question. Do you want me to drop this patch. If
that's not the case, can you confirm it does not break platforms that
didn't have those free OOB bytes exposed before this change.

Thanks,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mtd: nand: gpmi: get correct free oob space Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-29 10:40 +0200
  Re: [PATCH] mtd: nand: gpmi: get correct free oob space Han Xu <han.xu@nxp.com> - 2016-04-29 19:10 +0200

csiph-web