Re: [PATCH] efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver

From	Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver
Date	2016-04-29 10:40 +0200
Message-ID	<rtc7U-2Py-23@gated-at.bofh.it> (permalink)
References	<rrUZr-3iQ-1@gated-at.bofh.it> <rsRww-1zl-81@gated-at.bofh.it> <rtc7U-2Py-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 29 Apr, at 10:31:28AM, Ingo Molnar wrote:
> 
> So this commit triggered the follwing build warning on x86 64-bit allyesconfig:
 
Doh! I wonder why the 0day bot didn't tell me about this?

> It's this initialization in drivers/xen/efi.c:
> 
>   static const struct efi efi_xen __initconst = {
>   ...
>         .memmap                   = NULL, /* Not used under Xen. */
>   ...
> 
> which was forgotten about, as .memmap now is an embedded struct:
> 
>         struct efi_memory_map memmap;
> 
> We can remove this initialization - it's an EFI core internal data structure plus 
> it's not used in the Xen driver anyway.
> 
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
>  drivers/xen/efi.c | 1 -
>  1 file changed, 1 deletion(-)

Yep, looks good. Thanks Ingo!

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

Thread

[tip:efi/core] efi: Remove global 'memmap' EFI memory map tip-bot for Matt Fleming <tipbot@zytor.com> - 2016-04-28 12:40 +0200
  [PATCH] efi: Remove unnecessary (and buggy) .memmap initialization  from the Xen EFI driver Ingo Molnar <mingo@kernel.org> - 2016-04-29 10:40 +0200
    Re: [PATCH] efi: Remove unnecessary (and buggy) .memmap  initialization from the Xen EFI driver Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-29 10:40 +0200
    [tip:efi/core] efi: Remove unnecessary (and buggy) .memmap  initialization from the Xen EFI driver tip-bot for Ingo Molnar <tipbot@zytor.com> - 2016-04-29 12:00 +0200

csiph-web