Path: csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From: Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups: linux.kernel
Subject: Re: [PATCH] efi: Remove unnecessary (and buggy) .memmap  initialization from the Xen EFI driver
Date: Fri, 29 Apr 2016 10:40:02 +0200
Message-ID: <rtc7U-2Py-23@gated-at.bofh.it>
References: <rrUZr-3iQ-1@gated-at.bofh.it> <rsRww-1zl-81@gated-at.bofh.it> <rtc7U-2Py-17@gated-at.bofh.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30)
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 28
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1390867

On Fri, 29 Apr, at 10:31:28AM, Ingo Molnar wrote:
> 
> So this commit triggered the follwing build warning on x86 64-bit allyesconfig:
 
Doh! I wonder why the 0day bot didn't tell me about this?

> It's this initialization in drivers/xen/efi.c:
> 
>   static const struct efi efi_xen __initconst = {
>   ...
>         .memmap                   = NULL, /* Not used under Xen. */
>   ...
> 
> which was forgotten about, as .memmap now is an embedded struct:
> 
>         struct efi_memory_map memmap;
> 
> We can remove this initialization - it's an EFI core internal data structure plus 
> it's not used in the Xen driver anyway.
> 
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
>  drivers/xen/efi.c | 1 -
>  1 file changed, 1 deletion(-)

Yep, looks good. Thanks Ingo!

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>