Re: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Aleksa Sarai <cyphar@cyphar.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces
Date	Sun, 01 May 2016 15:30:02 +0200
Message-ID	<rtZBE-1IL-9@gated-at.bofh.it> (permalink)
References	<rtZih-1AP-3@gated-at.bofh.it> <rtZih-1AP-1@gated-at.bofh.it>
X-Original-To	Aleksa Sarai <asarai@suse.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cyphar-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=LMa9uqr0h2sCB5nK//OUmmJQtYZ7fUDakCq/ObUVt8w=; b=wLsSHcgZ15vUAa5J14Ci0IxspIkbHg8mCw8wbmE4vE6BKRs8S0olTNX5meHdPbwZ/r eB8CvqS4bk+l5cX7yaBq9fMe0HXM6rsEkpPK5U9tWIxYl4q9hysAPTzgN3vBHjYFjmsG kIrj6s0De2Y2q3Gx71+JYbULN8nOAPwVBbRXsp9KHm+qzDDkkbofjLWPFop0NFNqsDf7 Z1nJxh3Np85dt5NDDdcwLGJp5GeawZPL4lCzUJOH4jQXUiWTNkF/eKO0O07Xj9O1RgX8 9EUhQChTfIrpB5jLky8UJIm8uZL78gC9rSyZIvyz341ClX31gr5q34puIjjhDMmmfWYC +dJg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=LMa9uqr0h2sCB5nK//OUmmJQtYZ7fUDakCq/ObUVt8w=; b=GuQvDpmkMZhqXmNYkWX2nTlyuFn7TOktb0WEHLg7BUawB+woDm+7LjU61HTark0PdK zd8EOyi5YYW2QKvcy+vgLy7jPDfs165GKJAzBsz6S45zHOqlkFfp7qN0cJTKV13sEsDG IYPg1p0DRRi2TyztWVhVu429ATqG6sqVb/vvC7xUwniim8oIpgo6zmJqNwVHl0F56lO4 2SGOqjvfoK7rU2U2kFm1jQbeBEFqyyEhQphvqtPFpVjjcE2oFyDgAOHuZPXQ5OgEbyAt YFZL/MhjmQvBbueXA5lMb3wVrkL538iSBqnxzS1ihPM80S3CV1eOLzFFJ3t3IztO3pL7 +wZg==
X-Gm-Message-State	AOPr4FXCpw6mxxGMcAqGjRoDSBbk6EzuLTteSyObQU0efy5ZxcWcH8SlijAbwkvu03vhfITI5+BIkJhe9uqQ8w==
MIME-Version	1.0
X-Received	by 10.50.92.41 with SMTP id cj9mr14395686igb.22.1462108853636; Sun, 01 May 2016 06:20:53 -0700 (PDT)
X-Originating-IP	[122.106.150.15]
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	16
Organization	linux.* mail to news gateway
X-Original-Cc	Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>, Johannes Weiner <hannes@cmpxchg.org>, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, dev <dev@opencontainers.org>
X-Original-Date	Sun, 1 May 2016 23:20:53 +1000
X-Original-Message-ID	<CAOviyaikiTOCveWNuA+Och4SvHnXmZ07s0WDjc-JVo5avm6g-g@mail.gmail.com>
X-Original-References	<1462107838-9843-1-git-send-email-asarai@suse.de> <1462107838-9843-2-git-send-email-asarai@suse.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1391818

Show key headers only | View raw

> +err_unset_mode:
> +       /* Clean up the mode changes. */
> +       do_each_subsys_mask(ss, ssid, updated_mask) {
> +               struct kernfs_node *kn = cset->subsys[ssid]->cgroup->kn;
> +
> +               kernfs_break_active_protection(kn);
> +               cgroup_kn_set_mode(kn, mode[ssid]);
> +               kernfs_unbreak_active_protection(kn);
> +       } while_each_subsys_mask();

Sorry, I just realised this doesn't unlock all of the relevant locks
in the error path. I'll send an updated patch.

-- 
Aleksa Sarai (cyphar)
www.cyphar.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cgroup: allow management of subtrees by new cgroup namespaces Aleksa Sarai <asarai@suse.de> - 2016-05-01 15:10 +0200
  Re: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces Aleksa Sarai <cyphar@cyphar.com> - 2016-05-01 15:30 +0200

csiph-web