Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1391818

Re: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces

From Aleksa Sarai <cyphar@cyphar.com>
Newsgroups linux.kernel
Subject Re: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces
Date 2016-05-01 15:30 +0200
Message-ID <rtZBE-1IL-9@gated-at.bofh.it> (permalink)
References <rtZih-1AP-3@gated-at.bofh.it> <rtZih-1AP-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> +err_unset_mode:
> +       /* Clean up the mode changes. */
> +       do_each_subsys_mask(ss, ssid, updated_mask) {
> +               struct kernfs_node *kn = cset->subsys[ssid]->cgroup->kn;
> +
> +               kernfs_break_active_protection(kn);
> +               cgroup_kn_set_mode(kn, mode[ssid]);
> +               kernfs_unbreak_active_protection(kn);
> +       } while_each_subsys_mask();

Sorry, I just realised this doesn't unlock all of the relevant locks
in the error path. I'll send an updated patch.

-- 
Aleksa Sarai (cyphar)
www.cyphar.com

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] cgroup: allow management of subtrees by new cgroup namespaces Aleksa Sarai <asarai@suse.de> - 2016-05-01 15:10 +0200
  Re: [PATCH] cgroup: allow management of subtrees by new cgroup namespaces Aleksa Sarai <cyphar@cyphar.com> - 2016-05-01 15:30 +0200

csiph-web