Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390598

Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is available

Show all headers | View raw

On Thu, Apr 28, 2016 at 02:55:10PM -0700, Florian Fainelli wrote:
> Add a check whether the 'struct device_node' pointer passed to
> of_mdiobus_register() is an available (aka enabled) node in the Device
> Tree.
> 
> Rationale for doing this are cases where an Ethernet MAC provides a MDIO
> bus controller and node, and an additional Ethernet MAC might be
> connecting its PHY/switches to that first MDIO bus controller, while
> still embedding one internally which is therefore marked as "disabled".
> 
> Instead of sprinkling checks like these in callers of
> of_mdiobus_register(), do this in a central location.

I think this discussion has shown there is no documented best
practices for MDIO bus drivers and how PHYs nodes are placed within
device tree. Maybe you could document the generic MDIO binding, both
as integrated into a MAC device node, and as a separate device?

	   Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] of: of_mdio: Check if MDIO bus controller is available Florian Fainelli <f.fainelli@gmail.com> - 2016-04-29 00:00 +0200
  Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available Andrew Lunn <andrew@lunn.ch> - 2016-04-29 00:10 +0200
  Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available Andrew Lunn <andrew@lunn.ch> - 2016-04-29 00:20 +0200
    Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available Florian Fainelli <f.fainelli@gmail.com> - 2016-04-29 01:20 +0200
      Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available Andrew Lunn <andrew@lunn.ch> - 2016-04-29 01:30 +0200
  Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available David Miller <davem@davemloft.net> - 2016-05-02 01:40 +0200

csiph-web