Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390573

[PATCH net-next] of: of_mdio: Check if MDIO bus controller is available

Show all headers | View raw

Add a check whether the 'struct device_node' pointer passed to
of_mdiobus_register() is an available (aka enabled) node in the Device
Tree.

Rationale for doing this are cases where an Ethernet MAC provides a MDIO
bus controller and node, and an additional Ethernet MAC might be
connecting its PHY/switches to that first MDIO bus controller, while
still embedding one internally which is therefore marked as "disabled".

Instead of sprinkling checks like these in callers of
of_mdiobus_register(), do this in a central location.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/of/of_mdio.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index b622b33dbf93..2f497790be1b 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -209,6 +209,10 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
 	bool scanphys = false;
 	int addr, rc;
 
+	/* Do not continue if the node is disabled */
+	if (!of_device_is_available(np))
+		return -EINVAL;
+
 	/* Mask out all PHYs from auto probing.  Instead the PHYs listed in
 	 * the device tree are populated after the bus has been registered */
 	mdio->phy_mask = ~0;
-- 
2.1.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] of: of_mdio: Check if MDIO bus controller is available Florian Fainelli <f.fainelli@gmail.com> - 2016-04-29 00:00 +0200
  Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available Andrew Lunn <andrew@lunn.ch> - 2016-04-29 00:10 +0200
  Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available Andrew Lunn <andrew@lunn.ch> - 2016-04-29 00:20 +0200
    Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available Florian Fainelli <f.fainelli@gmail.com> - 2016-04-29 01:20 +0200
      Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available Andrew Lunn <andrew@lunn.ch> - 2016-04-29 01:30 +0200
  Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is  available David Miller <davem@davemloft.net> - 2016-05-02 01:40 +0200

csiph-web