Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1388586

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Show all headers | View raw

Hi,

On 04/26/2016 06:23 PM, Mark Brown wrote:
> On Tue, Apr 26, 2016 at 10:24:56AM +0800, Lu Baolu wrote:
>
>> The GPIO name might be different in different use cases. For my case,
>> it is "vbus_en", but other cases should use the different name.
>> On ACPI compatible platforms, GPIO resources are reported via ACPI
>> tables and (devm_)gpiod_get() hides the APCI complexity and returns
>> the gpiod according to "gpio_name".
> That's labelling that you might want to do on the supplier side or at
> system level.

The labeling is done at firmware level (ACPI 5.1). It uses _DSD
configuration object to give names to GPIOs. There are systems
which don't contain _DSD. On those platforms, Linux kernel
could do this instead.

Please refer to Documentation/acpi/gpio-properties.txt.

> Why does the device care?It's requesting the GPIO in
> its own context and it's only requesting one GPIO, with DT we're just
> always calling the GPIO "gpio" which works fine.

This driver is not bound to an ACPI device node directly. It's a child
of a mfd device, which is corresponding to a real ACPI device node.

I agree with you that we should not retrieve gpio name from the
device provider. Driver should have the knowledge of the gpio name.
(Please correct me if I didn't understand your point right. :-) )


Best regards,
Lu Baolu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 00/10] usb: add support for Intel dual role port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
  [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
    Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio  interface Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-26 02:00 +0200
      Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio  interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-26 02:50 +0200
  [PATCH v6 10/10] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
  [PATCH v6 03/10] regulator: fixed: add device binding for platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
    Re: [PATCH v6 03/10] regulator: fixed: add device binding for  platform device Mark Brown <broonie@kernel.org> - 2016-04-25 18:50 +0200
      Re: [PATCH v6 03/10] regulator: fixed: add device binding for  platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-26 04:20 +0200
  [PATCH v6 06/10] usb: mux: add driver for Intel gpio controlled port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
  [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
    Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-04-25 19:40 +0200
      Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-26 04:30 +0200
        Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-04-26 12:30 +0200
          Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-27 04:00 +0200
            Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-04-27 14:40 +0200
              Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-28 08:00 +0200
  [PATCH v6 09/10] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
  [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:20 +0200
    Re: [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform  device Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-26 02:00 +0200
      Re: [PATCH v6 01/10] extcon: usb-gpio: add device binding for  platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-26 02:50 +0200

csiph-web