Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1387007

Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface

From Chanwoo Choi <cw00.choi@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface
Date 2016-04-26 02:00 +0200
Message-ID <rrYA1-67A-1@gated-at.bofh.it> (permalink)
References <rrJKG-2lq-3@gated-at.bofh.it> <rrJKG-2lq-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Lu,

On 2016년 04월 25일 17:04, Lu Baolu wrote:
> GPIO resource could be retrieved through APCI as well.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Felipe Balbi <balbi@kernel.org>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/extcon/extcon-usb-gpio.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index af9c8b0..472c431 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -26,6 +26,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  #include <linux/workqueue.h>
> +#include <linux/acpi.h>
>  
>  #define USB_GPIO_DEBOUNCE_MS	20	/* ms */
>  
> @@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
>  	struct usb_extcon_info *info;
>  	int ret;
>  
> -	if (!np)
> +	if (!np && !ACPI_HANDLE(dev))
>  		return -EINVAL;
>  
>  	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
> 

Applied it.

Thanks,
Chanwoo Choi

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6 00/10] usb: add support for Intel dual role port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
  [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
    Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio  interface Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-26 02:00 +0200
      Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio  interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-26 02:50 +0200
  [PATCH v6 10/10] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
  [PATCH v6 03/10] regulator: fixed: add device binding for platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
    Re: [PATCH v6 03/10] regulator: fixed: add device binding for  platform device Mark Brown <broonie@kernel.org> - 2016-04-25 18:50 +0200
      Re: [PATCH v6 03/10] regulator: fixed: add device binding for  platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-26 04:20 +0200
  [PATCH v6 06/10] usb: mux: add driver for Intel gpio controlled port mux Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
  [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
    Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-04-25 19:40 +0200
      Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-26 04:30 +0200
        Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-04-26 12:30 +0200
          Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-27 04:00 +0200
            Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Mark Brown <broonie@kernel.org> - 2016-04-27 14:40 +0200
              Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-28 08:00 +0200
  [PATCH v6 09/10] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:10 +0200
  [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-25 10:20 +0200
    Re: [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform  device Chanwoo Choi <cw00.choi@samsung.com> - 2016-04-26 02:00 +0200
      Re: [PATCH v6 01/10] extcon: usb-gpio: add device binding for  platform device Lu Baolu <baolu.lu@linux.intel.com> - 2016-04-26 02:50 +0200

csiph-web