Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Alan Stern <stern@rowland.harvard.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv
Date	Tue, 26 Apr 2016 16:50:03 +0200
Message-ID	<rsctl-Xx-35@gated-at.bofh.it> (permalink)
References	<rrZPs-7hQ-11@gated-at.bofh.it>
X-Original-To	Jiancheng Xue <xuejiancheng@hisilicon.com>
X-X-Sender	stern@iolanthe.rowland.org
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	20
Organization	linux.* mail to news gateway
X-Original-Cc	linux-usb@vger.kernel.org, <linux-kernel@vger.kernel.org>, <yanhaifeng@hisilicon.com>, <yanghongwei@hisilicon.com>, <zhangzhenxing@hisilicon.com>, <suwenping@hisilicon.com>, <raojun@hisilicon.com>, <ml.yang@hisilicon.com>, <gaofei@hisilicon.com>, <hermit.wangheming@hisilicon.com>, <jiangheng@hisilicon.com>, <lpc.li@hisilicon.com>
X-Original-Date	Tue, 26 Apr 2016 10:49:47 -0400 (EDT)
X-Original-Message-ID	<Pine.LNX.4.44L0.1604261048080.2038-100000@iolanthe.rowland.org>
X-Original-References	<571EC16C.2050704@hisilicon.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1387564

Show key headers only | View raw

On Tue, 26 Apr 2016, Jiancheng Xue wrote:

> > If an error occurs here...
> > 
> Sorry. It's really a problem. I'll modify it in v2 like below:
> 
> err = reset_control_deassert(priv->rsts[rst]);
> if(err) {
> 	reset_control_put(priv->rsts[rst]);
> 	goto err_reset;
> }

Yes, that would be good.  (Except for the missing ' ' between "if" and 
"(".)

> Is it OK except this bug? If so, I'll send out v2 patch.

Everything else looked okay to me.

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-04-23 08:40 +0200
  Re: [PATCH] usb: ehci-platform: add reset controller number in struct  ehci_platform_priv Alan Stern <stern@rowland.harvard.edu> - 2016-04-25 16:50 +0200
    Re: [PATCH] usb: ehci-platform: add reset controller number in struct  ehci_platform_priv Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-04-26 03:20 +0200
      Re: [PATCH] usb: ehci-platform: add reset controller number in struct  ehci_platform_priv Alan Stern <stern@rowland.harvard.edu> - 2016-04-26 16:50 +0200

csiph-web