Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

From	Alan Stern <stern@rowland.harvard.edu>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv
Date	2016-04-26 16:50 +0200
Message-ID	<rsctl-Xx-35@gated-at.bofh.it> (permalink)
References	<rrZPs-7hQ-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 26 Apr 2016, Jiancheng Xue wrote:

> > If an error occurs here...
> > 
> Sorry. It's really a problem. I'll modify it in v2 like below:
> 
> err = reset_control_deassert(priv->rsts[rst]);
> if(err) {
> 	reset_control_put(priv->rsts[rst]);
> 	goto err_reset;
> }

Yes, that would be good.  (Except for the missing ' ' between "if" and 
"(".)

> Is it OK except this bug? If so, I'll send out v2 patch.

Everything else looked okay to me.

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-04-23 08:40 +0200
  Re: [PATCH] usb: ehci-platform: add reset controller number in struct  ehci_platform_priv Alan Stern <stern@rowland.harvard.edu> - 2016-04-25 16:50 +0200
    Re: [PATCH] usb: ehci-platform: add reset controller number in struct  ehci_platform_priv Jiancheng Xue <xuejiancheng@hisilicon.com> - 2016-04-26 03:20 +0200
      Re: [PATCH] usb: ehci-platform: add reset controller number in struct  ehci_platform_priv Alan Stern <stern@rowland.harvard.edu> - 2016-04-26 16:50 +0200

csiph-web