Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390482

Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready

Show all headers | View raw

On 28 April 2016 at 21:20, Mateusz Guzik <mguzik@redhat.com> wrote:
> In this case get_cmdline in mm/util.c should also be patched for
> completness. It tests for arg_end, but later accesses env_end.

But it'll do this only when argv[] was modified from what the kernel
initially wrote, which, in turn, either requires the process to have
started executing and messing with it's own argv[] or another process
poking at it via ptrace(). In the former case env_end will be non-zero
already and I don't know if the latter case is actually possible, i.e.
if one can already attach to a process this early. If one can, then
yes, that place needs to be modified, too.

Thanks,
Mathias

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready Mathias Krause <minipli@googlemail.com> - 2016-04-28 21:10 +0200
  Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's  ready Cyrill Gorcunov <gorcunov@gmail.com> - 2016-04-28 21:30 +0200
  Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's  ready Mateusz Guzik <mguzik@redhat.com> - 2016-04-28 21:30 +0200
    Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready Mathias Krause <minipli@googlemail.com> - 2016-04-28 21:40 +0200
    Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready Alexey Dobriyan <adobriyan@gmail.com> - 2016-04-29 12:20 +0200
  Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's  ready Andrew Morton <akpm@linux-foundation.org> - 2016-04-28 23:30 +0200
    Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready Mathias Krause <minipli@googlemail.com> - 2016-04-29 08:00 +0200
  Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's  ready Andrew Morton <akpm@linux-foundation.org> - 2016-04-28 23:40 +0200
    Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready Mathias Krause <minipli@googlemail.com> - 2016-04-29 08:10 +0200
      Re: [PATCH] proc: prevent accessing /proc/<PID>/environ until it's ready Alexey Dobriyan <adobriyan@gmail.com> - 2016-04-29 12:30 +0200

csiph-web