Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1390481

Re: [RFC PATCH v2 06/10] spi: add support for ACPI reconfigure notifications

Show all headers | View raw

On Thu, Apr 28, 2016 at 8:42 PM, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Apr 20, 2016 at 01:39:04AM +0300, Octavian Purdila wrote:
>
>> +     switch (value) {
>> +     case ACPI_RECONFIG_DEVICE_ADD:
>> +             master = acpi_spi_find_master_by_adev(adev->parent);
>> +             if (!master)
>> +                     break;
>> +
>> +             acpi_register_spi_device(master, adev);
>> +             put_device(&master->dev);
>> +             break;
>> +     case ACPI_RECONFIG_DEVICE_REMOVE:
>> +             spi = acpi_spi_find_device_by_adev(adev);
>> +             if (!spi)
>> +                     break;
>
> There's more code here now than I remember but this all looks *really*
> close to the DT code except for the OF_POPULATED flag that we set when
> things are instantiated in DT.  The duplication seems bad but the fact
> that we're missing the flag worries me...  do we have guarantees that
> ACPI won't double register?

We use the adev->flags.visited to check when a device has been already
enumerated, and we skip registering a new SPI slave in that case.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 00/10] ACPI overlays Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:40 +0200
  [RFC PATCH v2 01/10] kernel: add TAINT_OVERLAY_ACPI_TABLE Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:40 +0200
  [RFC PATCH v2 04/10] acpi: add support for ACPI reconfiguration notifiers Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:40 +0200
  [RFC PATCH v2 07/10] efi: load SSTDs from EFI variables Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:50 +0200
    Re: [RFC PATCH v2 07/10] efi: load SSTDs from EFI variables Jon Masters <jcm@redhat.com> - 2016-05-09 06:20 +0200
      Re: [RFC PATCH v2 07/10] efi: load SSTDs from EFI variables Octavian Purdila <octavian.purdila@intel.com> - 2016-05-09 12:00 +0200
  [RFC PATCH v2 02/10] acpi: decouple initrd table install from CONFIG_ACPI_INITRD_TABLE_OVERRIDE Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:50 +0200
  [RFC PATCH v2 09/10] acpi: add support for loading SSDTs via configfs Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:50 +0200
  [RFC PATCH v2 06/10] spi: add support for ACPI reconfigure notifications Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:50 +0200
    Re: [RFC PATCH v2 06/10] spi: add support for ACPI reconfigure  notifications Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-04-28 17:10 +0200
    Re: [RFC PATCH v2 06/10] spi: add support for ACPI reconfigure  notifications Mark Brown <broonie@kernel.org> - 2016-04-28 19:50 +0200
      Re: [RFC PATCH v2 06/10] spi: add support for ACPI reconfigure notifications Octavian Purdila <octavian.purdila@intel.com> - 2016-04-28 21:40 +0200
        Re: [RFC PATCH v2 06/10] spi: add support for ACPI reconfigure  notifications Mark Brown <broonie@kernel.org> - 2016-05-03 14:30 +0200
          Re: [RFC PATCH v2 06/10] spi: add support for ACPI reconfigure notifications Octavian Purdila <octavian.purdila@intel.com> - 2016-05-04 17:10 +0200
  [RFC PATCH v2 08/10] acpi: add support for configfs Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:50 +0200
  [RFC PATCH v2 05/10] i2c: add support for ACPI reconfigure notifications Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:50 +0200
    Re: [RFC PATCH v2 05/10] i2c: add support for ACPI reconfigure notifications Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-04-21 23:30 +0200
      Re: [RFC PATCH v2 05/10] i2c: add support for ACPI reconfigure notifications Octavian Purdila <octavian.purdila@intel.com> - 2016-04-21 23:50 +0200
    Re: [RFC PATCH v2 05/10] i2c: add support for ACPI reconfigure  notifications Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-04-28 17:00 +0200
  [RFC PATCH v2 10/10] HACK: acpi: configfs: add unload_hanlde_path attribute for tables Octavian Purdila <octavian.purdila@intel.com> - 2016-04-20 00:50 +0200

csiph-web