Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1390096
| Path | csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Maxime Coquelin <mcoquelin.stm32@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties |
| Date | Thu, 28 Apr 2016 14:10:04 +0200 |
| Message-ID | <rsSVC-2Qt-53@gated-at.bofh.it> (permalink) |
| References | <rrNlf-5e1-13@gated-at.bofh.it> <rrNlg-5e1-29@gated-at.bofh.it> |
| X-Original-To | Alexandre TORGUE <alexandre.torgue@gmail.com>, Rob Herring <robh@kernel.org> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=QAHjzJIENhNquj8Fqje/NCDK+TOEeRN8lgRzbzd7wcs=; b=xkI731mV+tM/dluPZKKR2id9l3dVlHoT247Llqk73Ehr+GGoBCV9mJd9a+2T3xVdl+ w7GjXEtvsxttGLzAgQFfMgq5MglIJi6Xizp+s6jwc94p2sXt18LivFZA0iTqZV+zu2sZ 7P7XikmXrRlgvavuxPjcbX/CrHSnJiSpZBPzbayvfHEQUrwn4OeUpZ84ZQ32MQYCmU9t HES/lctj0dQCMD2F8p6Y7sRku+Zq6vqWhDXm4HABvbcnvNmPBj1j4ELrPmzngvds2LI9 HafZBzUD2pEGayFeMTUDAnkz5MmzgfZ50uNudUIX2sInZq0XCaQGqyWQD/BCVx0eczxd bPDg== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=QAHjzJIENhNquj8Fqje/NCDK+TOEeRN8lgRzbzd7wcs=; b=ZXjuVGJtJTUSALoY9fO4wEV50sO7FTzDLeSlMNSdwi6aNE3KfU/dER69c4hzzARL2g 8tMRUALb2lZ5dctDzUpWkc1kbuHZOqp253N2HP8ge7qvt3f9VxwSraLwDMaEjgUC6ZvR gmm1izLP6bVYqQJJpTdc9q6SMeMwTKegUnrJvxDkuuWBi06fbP/cFyZOuCU215dKW5Ry YDn1QJuoT0XetvEXsdjb/T29ABc2+KlxrOdEia6/BrA+BIEbpH7hzXvfsWqm365BVq8S /i3jiLLCINnoshtIYHYed8h1shkKKXpSPu5DpIFmYqeR71GuW/wM8DXFqlgdnIE330mH KQGg== |
| X-Gm-Message-State | AOPr4FVvt037VUuu76vvz34gau1z1AQYV9U904Cq4/umDRkRQYkrKS8u4dY0SlEHX0he6ousdaaGa+81yvG/og== |
| MIME-Version | 1.0 |
| X-Received | by 10.140.39.243 with SMTP id v106mr13469856qgv.23.1461844877938; Thu, 28 Apr 2016 05:01:17 -0700 (PDT) |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 42 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Giuseppe Cavallaro <peppe.cavallaro@st.com>, netdev@vger.kernel.org, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Joachim Eastwood <manabian@gmail.com>, wens@csie.org |
| X-Original-Date | Thu, 28 Apr 2016 14:01:17 +0200 |
| X-Original-Message-ID | <CALszF6D4Uzqtw7GCmxTRpB7S8AGwnoj3uf36SywzDxV6Gg8iBw@mail.gmail.com> |
| X-Original-References | <1461585242-32401-1-git-send-email-alexandre.torgue@gmail.com> <1461585242-32401-6-git-send-email-alexandre.torgue@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1390096 |
Show key headers only | View raw
Hi Alex,
2016-04-25 13:54 GMT+02:00 Alexandre TORGUE <alexandre.torgue@gmail.com>:
> This patch aligns clocks names and node reference according to new
> stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle
> (indeed there is no need to add 0 as Ethernet instance as there is only
> one IP in SOC).
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>
>
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index 35df462..5995998 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -304,7 +304,7 @@
> };
> };
>
> - ethernet0_mii: mii@0 {
> + ethernet_mii: mii@0 {
> pins {
> pinmux = <STM32F429_PG13_FUNC_ETH_MII_TXD0_ETH_RMII_TXD0>,
> <STM32F429_PG14_FUNC_ETH_MII_TXD1_ETH_RMII_TXD1>,
> @@ -363,13 +363,13 @@
> st,mem2mem;
> };
>
> - ethernet0: dwmac@40028000 {
> + mac: ethernet@40028000 {
> compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
> reg = <0x40028000 0x8000>;
> reg-names = "stmmaceth";
> interrupts = <61>, <62>;
> interrupt-names = "macirq", "eth_wake_irq";
> - clock-names = "stmmaceth", "tx-clk", "rx-clk";
> + clock-names = "stmmaceth", "mac-clk-tx", "mac-clk-rx";
It looks good to me, but I will wait for Rob's ack on the bindings
documentation patch before applying it.
Regards,
Maxime
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v6 0/6] Add Ethernet support on STM32F429 Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
[PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
Re: [PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue Rob Herring <robh@kernel.org> - 2016-04-28 23:10 +0200
Re: [PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-04-29 13:30 +0200
[PATCH v6 1/6] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
[PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
Re: [PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-04-28 14:10 +0200
[PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-04-28 14:10 +0200
csiph-web