Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

From	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties
Date	2016-04-28 14:10 +0200
Message-ID	<rsSVC-2Qt-53@gated-at.bofh.it> (permalink)
References	<rrNlf-5e1-13@gated-at.bofh.it> <rrNlg-5e1-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Alex,

2016-04-25 13:54 GMT+02:00 Alexandre TORGUE <alexandre.torgue@gmail.com>:
> This patch aligns clocks names and node reference according to new
> stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle
> (indeed there is no need to add 0 as Ethernet instance as there is only
> one IP in SOC).
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com>
>
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index 35df462..5995998 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -304,7 +304,7 @@
>                                 };
>                         };
>
> -                       ethernet0_mii: mii@0 {
> +                       ethernet_mii: mii@0 {
>                                 pins {
>                                         pinmux = <STM32F429_PG13_FUNC_ETH_MII_TXD0_ETH_RMII_TXD0>,
>                                                  <STM32F429_PG14_FUNC_ETH_MII_TXD1_ETH_RMII_TXD1>,
> @@ -363,13 +363,13 @@
>                         st,mem2mem;
>                 };
>
> -               ethernet0: dwmac@40028000 {
> +               mac: ethernet@40028000 {
>                         compatible = "st,stm32-dwmac", "snps,dwmac-3.50a";
>                         reg = <0x40028000 0x8000>;
>                         reg-names = "stmmaceth";
>                         interrupts = <61>, <62>;
>                         interrupt-names = "macirq", "eth_wake_irq";
> -                       clock-names = "stmmaceth", "tx-clk", "rx-clk";
> +                       clock-names = "stmmaceth", "mac-clk-tx", "mac-clk-rx";

It looks good to me, but I will wait for Rob's ack on the bindings
documentation patch before applying it.

Regards,
Maxime

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/6] Add Ethernet support on STM32F429 Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
  [PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
    Re: [PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue Rob Herring <robh@kernel.org> - 2016-04-28 23:10 +0200
      Re: [PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-04-29 13:30 +0200
  [PATCH v6 1/6] net: ethernet: dwmac: add Ethernet glue logic for stm32 chip Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
  [PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
    Re: [PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-04-28 14:10 +0200
  [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties Alexandre TORGUE <alexandre.torgue@gmail.com> - 2016-04-25 14:00 +0200
    Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new  bindings properties Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-04-28 14:10 +0200

csiph-web