Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly
Date	2016-04-28 11:40 +0200
Message-ID	<rsQAp-Tg-1@gated-at.bofh.it> (permalink)
References	<rsGhH-P8-3@gated-at.bofh.it> <rsH46-1rb-13@gated-at.bofh.it> <rsQ7o-Ft-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 28 April 2016 11:08:41 Arnd Bergmann wrote:
> I only see two of them anyway (dreamcast and sh03), so that should
> be easy enough to do. For instance in arch/sh/boards/mach-sh03/rtc.c,
> the sh03_time_init() function should register a platform driver,
> whose probe function calls devm_rtc_device_register() to register
> with the rtc subsystem. Then you move the entire file to drivers/rtc/
> and change the callers of sh03_time_init() to create the device
> manually (for the classic board file) or drop it (for DT).

Just FYI:

Another look at the sh03_rtc_settimeofday function shows that it's
always been wrong: unlike the set_mmss() function it calls, it should
set all the time fields, not just minutes and seconds.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly Arnd Bergmann <arnd@arndb.de> - 2016-04-28 00:40 +0200
  Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly Rich Felker <dalias@libc.org> - 2016-04-28 01:30 +0200
    Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly Geert Uytterhoeven <geert@linux-m68k.org> - 2016-04-28 09:30 +0200
    Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly Arnd Bergmann <arnd@arndb.de> - 2016-04-28 11:10 +0200
      Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly Arnd Bergmann <arnd@arndb.de> - 2016-04-28 11:40 +0200

csiph-web