Re: [PATCH 2/2] tty: serial: msm_serial add info message

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] tty: serial: msm_serial add info message
Date	2016-04-25 23:40 +0200
Message-ID	<rrWoy-4fh-9@gated-at.bofh.it> (permalink)
References	<rr9nP-6Ka-15@gated-at.bofh.it> <rr9nQ-6Ka-27@gated-at.bofh.it> <rrVCa-3B8-27@gated-at.bofh.it> <rrWox-4fh-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 04/25, Frank Rowand wrote:
>
> This is in msm_request_tx_dma().  I should have made the message
> "msm_serial: TX DMA not enabled\n" and added a similar message
> to msm_request_rx_dma().
> 
> Then it could print twice, once for TX and once for RX. :-)
> For my board it would print twice because both requests would
> fail for the same reason.

Ah right, the 3 line diff window caught me here.

> 
> Should I add it to msm_request_rx_dma() also, but make both
> locations dev_debug() instead of dev_info()?

Honestly I don't see much point in having this at all. Why does
the user care if DMA is used or not? Don't they just want the
hardware to work? Maybe dev_dbg(), but again, debug junk. I'll
leave it up to you and Greg.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Thread

[PATCH 0/2] tty: serial: msm_serial regression and add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-23 19:20 +0200
  [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-23 19:20 +0200
    Re: [PATCH 2/2] tty: serial: msm_serial add info message Stephen Boyd <sboyd@codeaurora.org> - 2016-04-25 22:50 +0200
      Re: [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-25 23:40 +0200
        Re: [PATCH 2/2] tty: serial: msm_serial add info message Stephen Boyd <sboyd@codeaurora.org> - 2016-04-25 23:40 +0200
          Re: [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand <frowand.list@gmail.com> - 2016-04-26 02:50 +0200

csiph-web